Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert font stack changes #1592

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Revert font stack changes #1592

merged 2 commits into from
Sep 14, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Sep 14, 2021

This reverts the following PRs:

Reasoning

We got a few reports that these changes had negative effects for certain users. We still would like to fix the initial issue #1209, but it seems not that easy and needs some more careful testing.

Next steps

An approach we might can try next is to put these font changes behind a feature flag and then enable it only for certain users that would like to beta test it (Linux, Windows, Japanese, Chinese etc.). Once we find a good font stack that works for most, we can ship it to production to all users.

@simurai simurai requested a review from a team as a code owner September 14, 2021 00:54
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2021

🦋 Changeset detected

Latest commit: a1ad77e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@simurai simurai merged commit 39c9c92 into main Sep 14, 2021
@simurai simurai deleted the revert-body-font-changes branch September 14, 2021 00:58
@primer-css primer-css mentioned this pull request Sep 14, 2021
@NightFurySL2001
Copy link

Unless GitHub do either of the following things:

  1. providing a panel in user settings to write their own CSS font fallback list

or

  1. providing ways to tag the language of a Markdown/comment,

there will be no easy way out to write a CSS that will be good for most users without using system-ui. The benefit of listing system-ui in the first of font stack is that it will be changed based on system language (verified on Windows) and will display correctly using the system font, however all bets are off for languages not specified in system-ui which will depends on the fallback list in the system. Why? There are also Thai, Korean, Aboriginals, Arabic and more languages that currently can only use one font file to display their languages, and in the case of Chinese and Japanese they even share the same CJK Unified Ideographs but they should be displayed differently by their regions (See Source Han Sans for more info), and which one superseding the other in a fallback list will affect how the final display is shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants