Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert font stack changes #1592

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Revert font stack changes #1592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
298d3f9
Revert `$body-font` changes
simurai Sep 14, 2021
a1ad77e
Create thirty-pants-relate.md
simurai Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thirty-pants-relate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": minor
---

Revert font stack changes
23 changes: 1 addition & 22 deletions src/support/variables/typography.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,28 +32,7 @@ $lh-condensed: 1.25 !default;
$lh-default: 1.5 !default;

// Font stacks
$body-font:
// Apple OSs
-apple-system,
BlinkMacSystemFont,

// Windows
// Note this should be prioritized over `system-ui` to avoid legacy fonts.
// See https://infinnie.github.io/blog/2017/systemui.html
"Segoe UI Variable Text",
"Segoe UI",
"Meiryo", // Improves font rendering for Japanese, see https://github.com/primer/css/pull/1573.

// Linux-friendly system-level fonts + fallbacks
system-ui,
ui-sans-serif,
Helvetica,
Arial,
sans-serif,

// Emojis
"Apple Color Emoji",
"Segoe UI Emoji" !default;
$body-font: -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji" !default;

// Monospace font stack
// Note: SFMono-Regular needs to come before SF Mono to fix an older version of the font in Chrome
Expand Down