Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Tracking #3024

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Release Tracking #3024

merged 1 commit into from
Sep 3, 2024

Conversation

primer[bot]
Copy link
Contributor

@primer primer bot commented Aug 22, 2024 •
edited
Loading

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Minor Changes

Patch Changes

@primer primer bot requested a review from a team as a code owner August 22, 2024 16:40
@primer primer bot requested a review from jonrohan August 22, 2024 16:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 22, 2024 •
edited by camertron
Loading

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass
  • Lookbook opens in a browser
  • Successful integration test with GitHub.com as a primary consumer of Primer View Components
    • Install the npm release candidate: npm i -w ./npm-workspaces/primer/ @primer/view-components@next
    • Update primer_view_components gem: script/vendor-gem https://github.com/primer/view_components.git -r changeset-release/main
    • Verify no new build errors appear
    • Verify no new linting errors appear
    • Manually test critical paths
    • Manually test release-specific bugfixes and/or features work as described

🤔 Sanity test

  • All bugfixes in this release have resolved their corresponding issues
  • All new features in this release have been tested and verified as compatible with GitHub.com
  • No noticeable regressions have been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

Please also leave any testing notes as a comment on this pull request. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to maintainers.

@jonrohan jonrohan removed their request for review August 26, 2024 17:15
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@github-actions github-actions bot requested a review from a team as a code owner August 29, 2024 20:30
@camertron camertron merged commit fe577d5 into main Sep 3, 2024
38 checks passed
@camertron camertron deleted the changeset-release/main branch September 3, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camertron camertron camertron approved these changes

@langermank langermank Awaiting requested review from langermank langermank was automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@camertron