Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support voting flow #27

Merged
merged 2 commits into from
Mar 1, 2024
Merged

feat: support voting flow #27

merged 2 commits into from
Mar 1, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Feb 26, 2024 •
edited
Loading

  • Add useMaciVote hook
  • Integrate maci cli sdk publish batch method
  • Minor naming fixes
  • Update libs to support transaction final state
  • Add voting mutation with lock/unlock ballot
  • Add project id mapper to vote index
  • Fixes for new dependencies versions
  • Add vote limit for ballot and project selection

Blocked by #21
Blocked by privacy-scaling-explorations/maci#1251
Closes #7

@0xmad 0xmad added the enhancement New feature or request label Feb 26, 2024
@0xmad 0xmad self-assigned this Feb 26, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-rpgf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 7:05pm

@0xmad
feat: support voting flow
3011c55 
- [x] Update libs to support transaction final state
- [x] Add voting mutation with lock/unlock ballot
- [x] Add project id mapper to vote index
- [x] Fixes for new dependencies versions
@0xmad 0xmad marked this pull request as ready for review February 28, 2024 22:28
ctrlc03
ctrlc03 requested changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left a comment on the batch submission logic

src/hooks/useMaciVote.ts Show resolved Hide resolved
src/hooks/useMaciVote.ts Show resolved Hide resolved
kittybest
kittybest reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xmad seems like this PR contains 2 big things: bumping dependency versions and voting flow.
do you think we should split them and we could do more for the voting flow? (e.g. consider ctrl03's opinion on batch number stuff).
I could help the bumping version stuff.

@0xmad
Copy link
Collaborator Author

0xmad commented Feb 29, 2024

@0xmad seems like this PR contains 2 big things: bumping dependency versions and voting flow. do you think we should split them and we could do more for the voting flow? (e.g. consider ctrl03's opinion on batch number stuff). I could help the bumping version stuff.

Without dependency updates locking ballot won't work. Changes related to updates don't have many breaking changes, just minor fixes.

@0xmad 0xmad mentioned this pull request Mar 1, 2024
Open
@0xmad 0xmad requested review from ctrlc03 and kittybest March 1, 2024 19:05
@0xmad 0xmad mentioned this pull request Mar 1, 2024
Closed
ctrlc03
ctrlc03 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xmad 0xmad merged commit 9e01809 into main Mar 1, 2024
2 checks passed
@0xmad 0xmad deleted the feature/voting branch March 1, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@samajammin samajammin Awaiting requested review from samajammin

@kittybest kittybest Awaiting requested review from kittybest kittybest is a code owner

Assignees

@0xmad 0xmad

Labels
enhancement New feature or request
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Voting flow
4 participants
@0xmad @samajammin @kittybest @ctrlc03