-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add publish batch method for cli sdk #1251
Conversation
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1ea2b95
to
ac1a502
Compare
57ed941
to
22a22bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe also add publish test cmd in package.json
?
Unit tests can be run via |
22a22bd
to
843fe7e
Compare
I mean something like |
Ok, why do you need it? If I run tests for cli, I just run all the tests to make sure if nothing is broken. |
ok, then never mind. |
BigInt(coordinatorPubKeyResult.y.toString()), | ||
]); | ||
|
||
const encryptionKeypair = new Keypair(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the point of using the same key here for all messages in the batch, we just assume that all messages in the batch are from the same user either way for simplicity sake (though that doesn't necessarily have to be the case), so I would suggest we move line 226 out of the loop to avoid computing the ECDH key every time; and also we should probably return this key like we do in publishMessage.
Description
Add publish batch method for maci-cli sdk.
Additional Notes
N/A
Related issue(s)
Related to privacy-scaling-explorations/maci-platform#7
Confirmation