refactor(zk-kit-poseidon): remove old circomlib dependencies in crypto #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ctrlc03
force-pushed
the
deps/zk-kit-poseidon
branch
8 times, most recently
from
9694618 to
fcfae59
Compare
0xmad
approved these changes
Jan 3, 2024
crypto/ts/types.ts
Outdated
| export type Ciphertext = bigint[]; | ||
| // we define a bignumber as either a bigint or a string | ||
| // which is what we use the most in MACI | ||
| export type BigNumber = bigint | string; |
There was a problem hiding this comment.
I think this type can have conflicts if it's using with BigNumber from ethers of from bignumber.js. Maybe it makes sense to reuse BigNumberish type from ethers?
There was a problem hiding this comment.
Good shout, I can use that instead
There was a problem hiding this comment.
@0xmad What do you think about simply changing the type name? so we don't import from ethers and make further changes to the code
ctrlc03
force-pushed
the
deps/zk-kit-poseidon
branch
2 times, most recently
from
0930543 to
b6e5508
Compare
ctrlc03
force-pushed
the
deps/zk-kit-poseidon
branch
from
b6e5508 to
0340f79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes an old import (ciromlib) from the crypto library and instead imports the same functions from zk-kit. zk-kit provides lightweight TypeScript libraries for zk developers, allowing MACI's packages to be slimmer and more up to date.
Additional Notes
This is the first step into removing an old dependency, currently we still use it inside the circom circuits, and will be tackled in another PR.
@cedoor MACI 🤝 zk-kit
Related issue(s)
Re: #772
Additional Info
Let's merge #944 first
Confirmation