refactor(crypto): remove ffjavascript and implement utils functions locally #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ctrlc03
force-pushed
the
deps/ffjavascript
branch
2 times, most recently
from
3ee26d1 to
cf031ab
Compare
3 tasks
ctrlc03
force-pushed
the
deps/ffjavascript
branch
from
cf031ab to
34612a0
Compare
ctrlc03
force-pushed
the
deps/ffjavascript
branch
3 times, most recently
from
88ea91a to
419b013
Compare
…ocally Remove large dependency ffjavascript which was used only for a couple of util functions. Also ensure that we safely convert a bigint to a buffer and thus result in serialized maci private keys being the same length fix #458
ctrlc03
force-pushed
the
deps/ffjavascript
branch
from
419b013 to
0b2986f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the large dependency
ffjavascriptwhich was used only for a couple of util functions. Also ensure that we safely convert a bigint to a buffer and thus result in serialized maci private keys being the same length.Related issue(s)
Related to #793 and fix #458
Confirmation