Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix width/height not matching after get() #6542

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Fix width/height not matching after get() #6542

merged 1 commit into from
Nov 24, 2023

Conversation

davepagurek
Copy link
Contributor

Resolves #6540

Changes

  • Calls pixelDensity() on images created via get() rather than setting an internal property

Screenshots of the change

https://editor.p5js.org/davepagurek/sketches/6VuOKHnPv

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated
  • [Unit tests] are included / updated

@davepagurek davepagurek mentioned this pull request Nov 9, 2023
Closed
17 tasks
@Qianqianye Qianqianye added this to the 1.9.0 milestone Nov 23, 2023
@Qianqianye Qianqianye mentioned this pull request Nov 23, 2023
Closed
7 tasks
@limzykenneth limzykenneth merged commit a5fa292 into processing:main Nov 24, 2023
2 checks passed
@limzykenneth
Copy link
Member

Looks good. Thanks!

@davepagurek davepagurek deleted the fix/img-pixel-density branch November 24, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limzykenneth limzykenneth Awaiting requested review from limzykenneth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

get(x, y, w, h) output image width/height is doubled
3 participants
@davepagurek @limzykenneth @Qianqianye