Fix rounding of values close to 0 when computing smooth normals #6591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6590
Changes
I've updated the function to compute if vertices are the same to use rounding rather than
toFixed
.Let's say you have two vertices, one at x=-1e-8 and one at x=1e-8. Previouisly, using
toFixed
, these values become-0.000
and0.000
, which are different strings, so they don't end up equal. After this change, both end up0
.Screenshots of the change
Updated version of the sketch in the issue:
https://editor.p5js.org/davepagurek/sketches/WJ4DtuCcV
PR Checklist
npm run lint
passes