Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed example broken by #6216 and added information for new camera default setting #6620

Merged
merged 10 commits into from
Dec 15, 2023
Merged

Fixed example broken by #6216 and added information for new camera default setting #6620

merged 10 commits into from
Dec 15, 2023

Conversation

inaridarkfox4231
Copy link
Contributor

@inaridarkfox4231 inaridarkfox4231 commented Dec 10, 2023 •
edited
Loading

Due to #6216, many reference examples related to cameras were broken. The purpose is to restore it to its original state.

Resolves #6611

Changes: many.

Screenshots of the change:

before

かめら１

function setup() {
  createCanvas(100, 100, WEBGL);
  perspective(PI/3, 1, 5*sqrt(3), 500*sqrt(3));
  describe('a square moving closer and then away from the camera.');
}
function draw() {
  background(204);
  //move the camera away from the plane by a sin wave
  camera(0, 0, 20 + sin(frameCount * 0.01) * 10, 0, 0, 0, 0, 1, 0);
  plane(10, 10);
}

after

かめら２

PR Checklist

@inaridarkfox4231
Restore camera settings according to 100x100
d79fed1 
Restore camera settings according to 100x100
@inaridarkfox4231
Restore camera settings according to 100x100
bff13f9 
Restore camera settings according to 100x100
@inaridarkfox4231
fix setCamera
f9e4ec4 
Regarding the setCamera() example, the transition was not clean, so I modified the code.
@inaridarkfox4231
rotateX,Y,Z example fix
27c909a 
It looks like a parallel projection, so I'll fix it.
@inaridarkfox4231
Update light.js
2cf2d5e 
The way I set the background was sloppy, so I fixed it.
@inaridarkfox4231
Update 3d_primitives.js
c1c6222 
camera(0, 0, 50*sqrt(3), 0, 0, 0, 0, 1, 0);
perspective(PI/3, 1, 5*sqrt(3), 500*sqrt(3));
@inaridarkfox4231
Update p5.Camera.js
c87e949 
add information about new 80,800,8000 camera default system.
@inaridarkfox4231
indent fix
8a00549 
fix indent
@inaridarkfox4231 inaridarkfox4231 changed the title Fixed example broken by #6216 and added information for 80,800,8000 camera default setting Fixed example broken by #6216 and added information for new camera default setting Dec 11, 2023
@inaridarkfox4231
avoid to use image()
5c8df98 
The image() function uses push() to pop() internally, so the processing is duplicated and it's not pretty. Also, since it may be affected by imageMode(), I thought this would be better.
@inaridarkfox4231
add noLights()
15670d6 
add noLights()
@inaridarkfox4231
Copy link
Contributor Author

Please leave a review.

davepagurek
davepagurek approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for combing through all the examples!

@davepagurek davepagurek merged commit a1748ee into processing:main Dec 15, 2023
2 checks passed
@inaridarkfox4231 inaridarkfox4231 deleted the fix-the-camera-reference-bug branch December 15, 2023 22:56
@inaridarkfox4231 inaridarkfox4231 mentioned this pull request Jan 6, 2024
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davepagurek davepagurek davepagurek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Due to #6216, some of the reference examples related to cameras are broken.
2 participants
@inaridarkfox4231 @davepagurek