Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get visual tests running in 2.0 #7251

Merged
merged 4 commits into from
Sep 7, 2024
Merged

Get visual tests running in 2.0 #7251

merged 4 commits into from
Sep 7, 2024

Conversation

davepagurek
Copy link
Contributor

@davepagurek davepagurek commented Sep 7, 2024

This builds off of #7210 and gets visual tests running again. Some notes:

  • The library linked to from the vitest reference only works in node, and would be a bit of a pain to get the actual tests running in a browser, so I ended up not using it
  • Vite actually already provides server hooks into the browser for reading/writing files which I was able to use. I ended up just adapting the old visual test runner to use those hooks.
  • I added a diff library, resemblejs, to do the fuzzy matching. We'll probably want to test and tweak its settings more in the future.
  • I also found a bug in a WebGL test where vertex colors were not importing alpha correctly.

@davepagurek davepagurek mentioned this pull request Sep 7, 2024
Base automatically changed from fix/webgl to dev-2.0 September 7, 2024 18:01
@davepagurek davepagurek merged commit b1dd449 into dev-2.0 Sep 7, 2024
@davepagurek davepagurek deleted the fix/visual branch September 7, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants