-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Negative dimensions will mirror rect() again #7363
Conversation
Only applicable to shape mode `CORNER` Fixes processing#7353
This resolves the immediate issue by adjusting the position of the shape when using negative dimensions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your hard work on this! I truly appreciate the effort you've put in. There is one potential issue I wanted to mention regarding texture image handling. While you’ve done a great job adjusting the positioning in CORNERS, CORNER, etc., it seems that the image itself isn’t being flipped when necessary—only the position is being shifted. Adding a flip where needed could enhance the solution. Please let us know if there’s any way we can assist in exploring or addressing this aspect.
Expected:
Your's:
@perminder-17 Thanks for pointing that out, will look into it. |
@perminder-17 I think my latest commit should restore the original behavior. This means that |
ellipse() and arc() use absolute values
5010ebb
to
ebd00c2
Compare
@martinleopold Looks good. Thanks! |
Resolves #7353
Changes:
Fix a regression with negative values for width and/or height on rect(), ellipse(), and arc()
Screenshots of the change:
N/A
PR Checklist
npm run lint
passes