Fixing up liveness checks #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caseydavenport @fasaxc I think we can remove this test (https://github.com/projectcalico/felix/blob/2.6.x-series/fv/health_test.go#L228-L233) as the health server comes up during the start of the loop now and the only config we check for is the |
|
@fasaxc - please do take a look when you get in. I'm going to merge for now, but feel free to holler at me if we've moved in the wrong direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes projectcalico/calico#1532
The liveness checks were actually being done as we weren't kicking up the server for health checks.
Todos
Release Note