Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway API: Implement GRPCRoute #4820

Closed
sunjayBhatia opened this issue Oct 25, 2022 · 3 comments · Fixed by #5114
Closed

Gateway API: Implement GRPCRoute #4820

sunjayBhatia opened this issue Oct 25, 2022 · 3 comments · Fixed by #5114
Assignees
@fangfpeng @vmw-yingy
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
1.25.0

Comments

@sunjayBhatia
Copy link
Member

Please describe the problem you have
GRPCRoute is an experimental channel resource in Gateway API for: specifying routing behavior of gRPC requests from a Gateway listener to an API object, i.e. Service.

Given we've had a lot of requests for gRPC-backend app features etc. it would be nice to support gRPC in a more first-class manner with this resource.
@sunjayBhatia sunjayBhatia added kind/feature Categorizes issue or PR as related to a new feature. area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Oct 25, 2022
@sunjayBhatia
Copy link
Member Author

Proposal to move this into 1.24 or next release milestone, Gateway API upstream wants to graduate this resource and need implementations to start using it!

@skriss skriss removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Nov 1, 2022
@skriss skriss added this to Contour Nov 1, 2022
@skriss skriss moved this to Todo in Contour Nov 1, 2022
@skriss skriss added this to the 1.24.0 milestone Nov 1, 2022
@skriss
Copy link
Member

skriss commented Dec 16, 2022

cc @vmw-yingy @fangfpeng

@skriss
Copy link
Member

skriss commented Jan 6, 2023

ref. https://projectcontour.io/guides/grpc/

@skriss skriss modified the milestones: 1.24.0, 1.25.0 Jan 18, 2023
@skriss skriss moved this from Todo to In Progress in Contour Jan 20, 2023
fangfpeng added a commit to fangfpeng/contour that referenced this issue Jan 26, 2023
@fangfpeng
GRPCRoute: Add GRPCRoute support
09809ee 
Add kind and cache support for GRPCRoute

Updates projectcontour#4820

Signed-off-by: Fang Peng <[email protected]>
@fangfpeng fangfpeng mentioned this issue Jan 26, 2023
Merged
sunjayBhatia pushed a commit that referenced this issue Jan 26, 2023
@fangfpeng
GRPCRoute: Add GRPCRoute support (#5011)
bd2cd87 
Add kind and cache support for GRPCRoute

Updates #4820

Signed-off-by: Fang Peng <[email protected]>
vmw-yingy added a commit to vmw-yingy/contour that referenced this issue Jan 27, 2023
@vmw-yingy
GRPCRoute: add grpcRoute controller registration
0997c69 
add registration controller and reconcile support for GRPCRotue;
update handler and serve to call the registration.

Updates projectcontour#4820

Signed-off-by: Yu Ying <[email protected]>
@vmw-yingy vmw-yingy mentioned this issue Jan 27, 2023
Merged
vmw-yingy added a commit to vmw-yingy/contour that referenced this issue Jan 27, 2023
@vmw-yingy
GRPCRoute: enable RBAC permission to watch GRPCRoute
9ad65aa 
Updates projectcontour#4820

Signed-off-by: Yu Ying <[email protected]>
fangfpeng added a commit to fangfpeng/contour that referenced this issue Jan 28, 2023
@fangfpeng
internal/dag: Add GRPCRoute support in gatewayapi processor
6d4cc4a 
Implement gatewayapi_processor.go for building GRPCRoute dag.

todos:
- add GRPCRoute into allowed route kinds for listener with HTTP/HTTPS protocol
  This needs quite some changes on status_test.go for wanted SupportedKinds
  for listeners with http/http protocols.
- add unit tests

Updates projectcontour#4820
Signed-off-by: Fang Peng <[email protected]>
fangfpeng added a commit to fangfpeng/contour that referenced this issue Jan 28, 2023
@fangfpeng
internal/dag: Add GRPCRoute support in gatewayapi processor
9209755 
Implement gatewayapi_processor.go for building GRPCRoute dag.

todos:
- add GRPCRoute into allowed route kinds for listener with HTTP/HTTPS protocol
  This needs quite some changes on status_test.go for wanted SupportedKinds
  for listeners with http/http protocols.
- add unit tests

Updates projectcontour#4820

Signed-off-by: Fang Peng <[email protected]>
@fangfpeng fangfpeng mentioned this issue Jan 28, 2023
Merged
fangfpeng added a commit to fangfpeng/contour that referenced this issue Jan 29, 2023
@fangfpeng
internal/dag: add GRPCRoute into allowed route kinds
3c15b90 
add GRPCRoute into allowed route kinds for listener with HTTP/HTTPS protocol
update existing tests in status_test.go

Updates projectcontour#4820

Signed-off-by: Fang Peng <[email protected]>
vmw-yingy added a commit to vmw-yingy/contour that referenced this issue Jan 31, 2023
@vmw-yingy
GRPCRoute: enable RBAC permission on cluster role
db37cc2 
Update projectcontour#4820

Signed-off-by: Yu Ying <[email protected]>
skriss pushed a commit that referenced this issue Jan 31, 2023
@vmw-yingy
GRPCRoute: add grpcRoute controller registration (#5018)
7ede833 
add registration controller and reconcile support for GRPCRoute;
update handler and serve to call the registration.

Updates #4820

Signed-off-by: Yu Ying <[email protected]>
skriss pushed a commit that referenced this issue Feb 9, 2023
@fangfpeng
internal/dag: Add GRPCRoute support in gatewayapi processor (#5021)
e31d89a 
Implement gatewayapi_processor.go for building GRPCRoute dag.

Updates #4820

Signed-off-by: Fang Peng <[email protected]>
vmw-yingy added a commit to vmw-yingy/contour that referenced this issue Feb 17, 2023
@vmw-yingy
GRPCRotue: add ut test cases
b78ba1a 
for 1.TestGetListenersForRotueParentRef
    2.TestDAGInsertGatewayAPI

Updates projectcontour#4820

Signed-off-by: Yu Ying <[email protected]>
vmw-yingy added a commit to vmw-yingy/contour that referenced this issue Feb 17, 2023
@vmw-yingy
GRPCRoute: set default protocol type for mirrored service
413a993 
Updates projectcontour#4820

Signed-off-by: Yu Ying <[email protected]>
vmw-yingy added a commit to vmw-yingy/contour that referenced this issue Feb 17, 2023
@vmw-yingy
GRPCRoute: remove unnecessary type conversion and comment
369f316 
Updates projectcontour#4820

Signed-off-by: Yu Ying <[email protected]>
skriss pushed a commit that referenced this issue Feb 21, 2023
@vmw-yingy
GRPCRoute: add unit test cases (#5104)
6399566 
* GRPCRotue: add ut test cases

for 1.TestGetListenersForRotueParentRef
    2.TestDAGInsertGatewayAPI

Updates #4820

Signed-off-by: Yu Ying <[email protected]>

* GRPCRoute: set default protocol type for mirrored service

Updates #4820

Signed-off-by: Yu Ying <[email protected]>

* GRPCRoute: remove unnecessary type conversion and comment

Updates #4820

Signed-off-by: Yu Ying <[email protected]>

---------

Signed-off-by: Yu Ying <[email protected]>
fangfpeng added a commit to fangfpeng/contour that referenced this issue Feb 22, 2023
@fangfpeng
internal/dag: Add more status test for GRPCRoute
6ba6f93 
Updates projectcontour#4820

Signed-off-by: Fang Peng <[email protected]>
@fangfpeng fangfpeng mentioned this issue Feb 22, 2023
Merged
skriss pushed a commit that referenced this issue Feb 22, 2023
@fangfpeng
internal/dag: Add more status test for GRPCRoute (#5115)
89088ba 
Updates #4820

Signed-off-by: Fang Peng <[email protected]>
@skriss skriss mentioned this issue Feb 22, 2023
Merged
fangfpeng added a commit to fangfpeng/contour that referenced this issue Feb 22, 2023
@fangfpeng
internal/dag: fix method match of GRPCRoute
65d7a4c 
- need to add a leading slash in the path
- need to add a prefix match if method match is not
specified.

Updates projectcontour#4820

Signed-off-by: Fang Peng <[email protected]>
@fangfpeng fangfpeng mentioned this issue Feb 22, 2023
Merged
skriss pushed a commit that referenced this issue Feb 22, 2023
@fangfpeng
internal/dag: fix method match of GRPCRoute (#5116)
ecd5c59 
- need to add a leading slash in the path
- need to add a prefix match if method match is not
specified.
- internal-dag: Add default prefix match with 0 matches

Updates #4820

Signed-off-by: Fang Peng <[email protected]>
vmw-yingy added a commit to vmw-yingy/contour that referenced this issue Feb 24, 2023
@vmw-yingy
Gateway API: update grpc.md for GRPCRoute usage
126fc75 
Updates projectcontour#4820

Signed-off-by: Yu Ying <[email protected]>
@vmw-yingy vmw-yingy mentioned this issue Feb 24, 2023
Closed
vmw-yingy added a commit to vmw-yingy/contour that referenced this issue Feb 24, 2023
@vmw-yingy
Updating grpc.md based on CI feedback
f04c1ec 
Updates projectcontour#4820

Signed-off-by: Yu Ying <[email protected]>
skriss pushed a commit that referenced this issue Feb 27, 2023
@fangfpeng @vmw-yingy
Gateway API: add GRPCRoute support (#5114)
cc1cb8c 
Adds support for Gateway API's GRPCRoute,
an experimental v1alpha2 resource as of Gateway
API v0.6. Core conformance features are currently
implemented.

Closes #4820.

Co-authored-by: Yu Ying <[email protected]>
Signed-off-by: Fang Peng <[email protected]>
Signed-off-by: Yu Ying <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Contour Feb 27, 2023
vmw-yingy added a commit to vmw-yingy/contour that referenced this issue Feb 28, 2023
@fangfpeng @vmw-yingy
Gateway API: add GRPCRoute support (projectcontour#5114)
9a893f8 
Adds support for Gateway API's GRPCRoute,
an experimental v1alpha2 resource as of Gateway
API v0.6. Core conformance features are currently
implemented.

Closes projectcontour#4820.

Co-authored-by: Yu Ying <[email protected]>
Signed-off-by: Fang Peng <[email protected]>
Signed-off-by: Yu Ying <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fangfpeng fangfpeng

@vmw-yingy vmw-yingy

Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Contour
Status: Done
Milestone
1.25.0
Development

Successfully merging a pull request may close this issue.

Gateway API: add GRPCRoute support projectcontour/contour
4 participants
@skriss @sunjayBhatia @fangfpeng @vmw-yingy