Gateway API: add GRPCRoute support

[fangfpeng]

Closes #4820.

[codecov]

Codecov Report

Merging #5114 (ba1495d) into main (157887a) will increase coverage by 0.03%.
The diff coverage is 80.20%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5114      +/-   ##
==========================================
+ Coverage   77.97%   78.01%   +0.03%     
==========================================
  Files         137      138       +1     
  Lines       17237    17604     +367     
==========================================
+ Hits        13441    13733     +292     
- Misses       3536     3600      +64     
- Partials      260      271      +11     

Impacted Files	Coverage Δ
cmd/contour/serve.go	22.20% <0.00%> (-0.10%)	⬇️
internal/status/routeconditions.go	51.04% <0.00%> (-6.61%)	⬇️
internal/controller/grpcroute.go	25.80% <25.80%> (ø)
internal/dag/policy.go	94.76% <80.00%> (+0.01%)	⬆️
internal/dag/gatewayapi_processor.go	93.98% <87.03%> (-1.84%)	⬇️
internal/contour/handler.go	90.00% <100.00%> (+0.07%)	⬆️
internal/dag/cache.go	94.36% <100.00%> (+0.10%)	⬆️
internal/gatewayapi/helpers.go	87.94% <100.00%> (+2.98%)	⬆️
internal/k8s/kind.go	60.78% <100.00%> (+1.60%)	⬆️
...ovisioner/objects/rbac/clusterrole/cluster_role.go	78.94% <100.00%> (ø)
... and 1 more

[skriss]

Overall looking good, had a few small comment

[skriss]

FYI, with this path match fix in place, I was able to get gRPC traffic routing!

I used the yages example service from https://projectcontour.io/docs/v1.24.1/guides/grpc/ as the backend.

Here's the GRPCRoute I used (note it includes a match for the gRPC reflection service, which is needed by grpcurl):

apiVersion: gateway.networking.k8s.io/v1alpha2
kind: GRPCRoute
metadata:
  name: yages
spec:
  parentRefs:
  - namespace: projectcontour
    name: contour
  hostnames:
  - my-grpc-service.foo.com 
  rules:
  - matches:
    - method:
        service: yages.Echo
        method: Ping
    - method:
        service: grpc.reflection.v1alpha.ServerReflection
        method: ServerReflectionInfo
    backendRefs:
    - name: grpc-echo
      port: 9000

My method for getting this up and running was roughly:

• make setup-kind-cluster
• make load-contour-image-kind
• update examples/render/contour-gateway.yaml to use imagePullPolicy: IfNotPresent instead of imagePullPolicy: Always
• kubectl apply -f examples/render/contour-gateway.yaml
• Deploy the yages example server linked above
• Create the GPRCRoute from above
• Use grpcurl to test per https://projectcontour.io/docs/v1.24.1/guides/grpc/

[fangfpeng]

FYI, with this path match fix in place, I was able to get gRPC traffic routing!

I used the yages example service from https://projectcontour.io/docs/v1.24.1/guides/grpc/ as the backend.

Here's the GRPCRoute I used (note it includes a match for the gRPC reflection service, which is needed by grpcurl):

apiVersion: gateway.networking.k8s.io/v1alpha2
kind: GRPCRoute
metadata:
  name: yages
spec:
  parentRefs:
  - namespace: projectcontour
    name: contour
  hostnames:
  - my-grpc-service.foo.com 
  rules:
  - matches:
    - method:
        service: yages.Echo
        method: Ping
    - method:
        service: grpc.reflection.v1alpha.ServerReflection
        method: ServerReflectionInfo
    backendRefs:
    - name: grpc-echo
      port: 9000

This is great news! I will make the suggested path prefix fix.

[skriss]

@fangfpeng @vmw-yingy this is looking pretty good! There are still a few (minor) outstanding review comments above, and this PR will need a changelog file as well.

[skriss]

LGTM! Will leave for @sunjayBhatia to take another look at as well. Thanks @fangfpeng and @vmw-yingy for all your work on this.

[sunjayBhatia]

LGTM great work!

I'm thinking we should add some e2e tests while upstream Gateway API conformance is missing them, but that can definitely be done in a follow-up!