Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from Dep to go modules #598

Closed
davecheney opened this issue Jul 31, 2018 · 5 comments
Closed

Switch from Dep to go modules #598

davecheney opened this issue Jul 31, 2018 · 5 comments
Assignees
@davecheney
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
0.12.0

Comments

@davecheney
Copy link
Contributor

Requires #597

https://go-review.googlesource.com/c/go/+/124384 introduces support for a v8.0.0+incompatible annotation in the go.mod file which should provide a bridge between semver dependencies and go 1.11 Semantic Import Versioning requirement. This will let us update go.mod without having to wait for k8s.io/client-go to rewrite the repository.
@davecheney davecheney added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 31, 2018
@davecheney davecheney added this to the 0.7.0 milestone Jul 31, 2018
@davecheney davecheney self-assigned this Jul 31, 2018
@davecheney davecheney removed this from the 0.7.0 milestone Oct 8, 2018
@davecheney
Copy link
Contributor Author

Removing milestone, #691 is not going to happen for 0.7 and we might skip Go 1.11 completely.

@davecheney davecheney added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 11, 2018
@davecheney davecheney added this to the 0.12.0 milestone Mar 12, 2019
@davecheney
Copy link
Contributor Author

Revisit after #848

@vaamarnath vaamarnath mentioned this issue Mar 13, 2019
Merged
@davecheney davecheney added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Mar 18, 2019
@davecheney
Copy link
Contributor Author

This issue is open for anyone who wants to try it.

@vaamarnath
Copy link
Contributor

I can pick it up @davecheney

@vaamarnath vaamarnath mentioned this issue Mar 18, 2019
Merged
@vaamarnath
Copy link
Contributor

I have chosen to vendor the dependencies using go mod vendor. I have made the changes accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davecheney davecheney

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
2 participants
@davecheney @vaamarnath