-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(runner): adjust max-host-error
if gt concurrency
#5633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue` also it exports the method Signed-off-by: Dwi Siswanto <[email protected]>
Signed-off-by: Dwi Siswanto <[email protected]>
dogancanbakir
approved these changes
Sep 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm !
the scan completed without any max-host-error issue even with -c 200
$ ./nuclei -u https://scanme.sh -c 200 -stats
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v3.3.2
projectdiscovery.io
[WRN] The concurrency value is higher than max-host-error
[INF] Adjusting max-host-error to the concurrency value
[WRN] Found 1 templates with runtime error (use -validate flag for further examination)
[INF] Current nuclei version: v3.3.2 (latest)
[INF] Current nuclei-templates version: v10.0.0 (latest)
[WRN] Scan results upload to cloud is disabled.
[INF] New templates added in latest release: 255
[INF] Templates loaded for current scan: 8550
[INF] Executing 8549 signed templates from projectdiscovery/nuclei-templates
[WRN] Loading 1 unsigned templates for scan. Use with caution.
[INF] Targets loaded for current scan: 1
[INF] Templates clustered: 1600 (Reduced 1512 Requests)
[0:00:05] | Templates: 8550 | Hosts: 1 | RPS: 152 | Matched: 0 | Errors: 753 | Requests: 801/14129 (5%)
[INF] Using Interactsh Server: oast.live
[0:00:10] | Templates: 8550 | Hosts: 1 | RPS: 125 | Matched: 0 | Errors: 762 | Requests: 1286/14129 (9%)
[0:00:15] | Templates: 8550 | Hosts: 1 | RPS: 121 | Matched: 0 | Errors: 763 | Requests: 1858/14129 (13%)
[0:00:20] | Templates: 8550 | Hosts: 1 | RPS: 143 | Matched: 0 | Errors: 771 | Requests: 2906/14129 (20%)
[0:00:25] | Templates: 8550 | Hosts: 1 | RPS: 147 | Matched: 0 | Errors: 771 | Requests: 3727/14129 (26%)
[0:00:30] | Templates: 8550 | Hosts: 1 | RPS: 149 | Matched: 0 | Errors: 773 | Requests: 4508/14129 (31%)
[0:00:35] | Templates: 8550 | Hosts: 1 | RPS: 142 | Matched: 0 | Errors: 773 | Requests: 5024/14129 (35%)
[ssh-server-enumeration] [javascript] [info] scanme.sh:22 ["SSH-2.0-OpenSSH_8.2p1 Ubuntu-4ubuntu0.11"]
[ssh-sha1-hmac-algo] [javascript] [info] scanme.sh:22
[ssh-password-auth] [javascript] [info] scanme.sh:22
[openssh-detect] [tcp] [info] scanme.sh:22 ["SSH-2.0-OpenSSH_8.2p1 Ubuntu-4ubuntu0.11"]
[deprecated-tls:tls_1.1] [ssl] [info] scanme.sh:443 ["tls11"]
[tls-version] [ssl] [info] scanme.sh:443 ["tls10"]
[tls-version] [ssl] [info] scanme.sh:443 ["tls11"]
[deprecated-tls:tls_1.0] [ssl] [info] scanme.sh:443 ["tls10"]
[weak-cipher-suites:tls-1.0] [ssl] [low] scanme.sh:443 ["[tls10 TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA]"]
[tls-version] [ssl] [info] scanme.sh:443 ["tls12"]
[weak-cipher-suites:tls-1.1] [ssl] [low] scanme.sh:443 ["[tls11 TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA]"]
[tls-version] [ssl] [info] scanme.sh:443 ["tls13"]
[0:00:40] | Templates: 8550 | Hosts: 1 | RPS: 145 | Matched: 12 | Errors: 888 | Requests: 5844/14129 (41%)
[0:00:45] | Templates: 8550 | Hosts: 1 | RPS: 143 | Matched: 12 | Errors: 890 | Requests: 6501/14129 (46%)
[0:00:50] | Templates: 8550 | Hosts: 1 | RPS: 143 | Matched: 12 | Errors: 898 | Requests: 7212/14129 (51%)
[0:00:55] | Templates: 8550 | Hosts: 1 | RPS: 143 | Matched: 12 | Errors: 902 | Requests: 7933/14129 (56%)
[0:01:00] | Templates: 8550 | Hosts: 1 | RPS: 144 | Matched: 12 | Errors: 902 | Requests: 8681/14129 (61%)
[0:01:05] | Templates: 8550 | Hosts: 1 | RPS: 144 | Matched: 12 | Errors: 914 | Requests: 9438/14129 (66%)
[http-missing-security-headers:strict-transport-security] [http] [info] https://scanme.sh
[http-missing-security-headers:permissions-policy] [http] [info] https://scanme.sh
[http-missing-security-headers:cross-origin-embedder-policy] [http] [info] https://scanme.sh
[http-missing-security-headers:cross-origin-resource-policy] [http] [info] https://scanme.sh
[http-missing-security-headers:referrer-policy] [http] [info] https://scanme.sh
[http-missing-security-headers:clear-site-data] [http] [info] https://scanme.sh
[http-missing-security-headers:cross-origin-opener-policy] [http] [info] https://scanme.sh
[http-missing-security-headers:content-security-policy] [http] [info] https://scanme.sh
[http-missing-security-headers:x-frame-options] [http] [info] https://scanme.sh
[http-missing-security-headers:x-content-type-options] [http] [info] https://scanme.sh
[http-missing-security-headers:x-permitted-cross-domain-policies] [http] [info] https://scanme.sh
[0:01:10] | Templates: 8550 | Hosts: 1 | RPS: 145 | Matched: 23 | Errors: 918 | Requests: 10188/14129 (72%)
[ssl-issuer] [ssl] [info] scanme.sh:443 ["pd"]
[mismatched-ssl-certificate] [ssl] [low] scanme.sh:443 ["CN: scanme"]
[self-signed-ssl] [ssl] [low] scanme.sh:443
[0:01:15] | Templates: 8550 | Hosts: 1 | RPS: 145 | Matched: 26 | Errors: 918 | Requests: 10937/14129 (77%)
[caa-fingerprint] [dns] [info] scanme.sh
[nameserver-fingerprint] [dns] [info] scanme.sh ["ns70.domaincontrol.com.","ns69.domaincontrol.com."]
[0:01:20] | Templates: 8550 | Hosts: 1 | RPS: 144 | Matched: 28 | Errors: 921 | Requests: 11582/14129 (81%)
[0:01:25] | Templates: 8550 | Hosts: 1 | RPS: 138 | Matched: 28 | Errors: 921 | Requests: 11765/14129 (83%)
[0:01:30] | Templates: 8550 | Hosts: 1 | RPS: 130 | Matched: 28 | Errors: 921 | Requests: 11811/14129 (83%)
[0:01:35] | Templates: 8550 | Hosts: 1 | RPS: 124 | Matched: 28 | Errors: 921 | Requests: 11858/14129 (83%)
[0:01:40] | Templates: 8550 | Hosts: 1 | RPS: 118 | Matched: 28 | Errors: 921 | Requests: 11905/14129 (84%)
[0:01:45] | Templates: 8550 | Hosts: 1 | RPS: 113 | Matched: 28 | Errors: 921 | Requests: 11953/14129 (84%)
[0:01:50] | Templates: 8550 | Hosts: 1 | RPS: 108 | Matched: 28 | Errors: 921 | Requests: 12000/14129 (84%)
[0:01:55] | Templates: 8550 | Hosts: 1 | RPS: 104 | Matched: 28 | Errors: 921 | Requests: 12038/14129 (85%)
[0:02:00] | Templates: 8550 | Hosts: 1 | RPS: 100 | Matched: 28 | Errors: 921 | Requests: 12062/14129 (85%)
[0:02:05] | Templates: 8550 | Hosts: 1 | RPS: 96 | Matched: 28 | Errors: 921 | Requests: 12085/14129 (85%)
[0:02:10] | Templates: 8550 | Hosts: 1 | RPS: 92 | Matched: 28 | Errors: 921 | Requests: 12109/14129 (85%)
[0:02:15] | Templates: 8550 | Hosts: 1 | RPS: 89 | Matched: 28 | Errors: 921 | Requests: 12132/14129 (85%)
[0:02:20] | Templates: 8550 | Hosts: 1 | RPS: 86 | Matched: 28 | Errors: 921 | Requests: 12155/14129 (86%)
[0:02:25] | Templates: 8550 | Hosts: 1 | RPS: 83 | Matched: 28 | Errors: 921 | Requests: 12178/14129 (86%)
[0:02:30] | Templates: 8550 | Hosts: 1 | RPS: 81 | Matched: 28 | Errors: 921 | Requests: 12202/14129 (86%)
[0:02:35] | Templates: 8550 | Hosts: 1 | RPS: 78 | Matched: 28 | Errors: 921 | Requests: 12226/14129 (86%)
[0:02:40] | Templates: 8550 | Hosts: 1 | RPS: 76 | Matched: 28 | Errors: 921 | Requests: 12233/14129 (86%)
[0:02:42] | Templates: 8550 | Hosts: 1 | RPS: 75 | Matched: 28 | Errors: 921 | Requests: 12233/14129 (86%)
P.S since we are printing the info statement maybe we should also print the actual values that are being updated automatically ( ex: 30 -> 200 )
Signed-off-by: Dwi Siswanto <[email protected]>
dwisiswant0
force-pushed
the
dwisiswant0/refactor/max-host-error
branch
from
September 15, 2024 21:01
041840d
to
1584019
Compare
ehsandeep
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix #5564
Checklist