Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider protocolType in max host error #5668

Merged
merged 2 commits into from
Sep 28, 2024
Merged

consider protocolType in max host error #5668

merged 2 commits into from
Sep 28, 2024

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Sep 27, 2024 •
edited
Loading

Proposed Changes

Follow up fix for #5633

  • skip max-host-error logic in tcp and javascript templates
  • consider protocolType when calculating max-host-error

the cause behind recent max host errors was legitemate i/o timeout and connection reset by peer errors which happen in tcp and javascript payloads

@tarunKoyalwar tarunKoyalwar self-assigned this Sep 27, 2024
@tarunKoyalwar tarunKoyalwar marked this pull request as ready for review September 27, 2024 20:55
@auto-assign auto-assign bot requested a review from dogancanbakir September 27, 2024 20:55
@ehsandeep ehsandeep merged commit 1f945d6 into dev Sep 28, 2024
12 checks passed
@ehsandeep ehsandeep deleted the add-proto-prefix branch September 28, 2024 13:20
@BrewTestBot BrewTestBot mentioned this pull request Sep 28, 2024
Merged
@blsaccess blsaccess mentioned this pull request Sep 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogancanbakir dogancanbakir dogancanbakir approved these changes

@dwisiswant0 dwisiswant0 dwisiswant0 approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@tarunKoyalwar tarunKoyalwar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tarunKoyalwar @ehsandeep @dwisiswant0 @dogancanbakir