Feature - Title click listener #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiensi
reviewed
Feb 14, 2017
| */ | ||
| public void setOnTitleClickListener(final OnClickListener listener) { | ||
| if (listener != null) { | ||
| title.setOnClickListener(listener); |
There was a problem hiding this comment.
What's wrong with setting the listener to null if it should already be guarding for null listeners
| widget.setOnTitleClickListener(new View.OnClickListener() { | ||
| @Override | ||
| public void onClick(final View view) { | ||
| Toast.makeText(DynamicSettersActivity.this, "Today is the day", Toast.LENGTH_SHORT) |
There was a problem hiding this comment.
string resources? or does it not matter
| @@ -222,7 +222,7 @@ public void onPageScrolled(int position, float positionOffset, int positionOffse | |||
| private OnDateSelectedListener listener; | |||
| private OnMonthChangedListener monthListener; | |||
| private OnRangeSelectedListener rangeListener; | |||
|
|
|||
| private OnClickListener titleListener; | |||
| */ | ||
| public void setOnTitleClickListener(final OnClickListener listener) { | ||
| if (listener != null) { | ||
| title.setOnClickListener(listener); |
There was a problem hiding this comment.
is there something wrong with setting anull click listener?
There was a problem hiding this comment.
Actually no, that's how you remove it! I will cleanup, thanks
|
@tiensi Updated following comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@prolificinteractive/android-devs