-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Title click listener #512
Changes from 3 commits
d03eac0
d10f273
1795c1b
454b276
a97c138
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -222,7 +222,7 @@ public void onPageScrolled(int position, float positionOffset, int positionOffse | |
private OnDateSelectedListener listener; | ||
private OnMonthChangedListener monthListener; | ||
private OnRangeSelectedListener rangeListener; | ||
|
||
private OnClickListener titleListener; | ||
|
||
CharSequence calendarContentDescription; | ||
private int accentColor = 0; | ||
|
@@ -262,7 +262,6 @@ public MaterialCalendarView(Context context, AttributeSet attrs) { | |
buttonFuture.setContentDescription(getContext().getString(R.string.next)); | ||
pager = new CalendarPager(getContext()); | ||
|
||
title.setOnClickListener(onClickListener); | ||
buttonPast.setOnClickListener(onClickListener); | ||
buttonFuture.setOnClickListener(onClickListener); | ||
|
||
|
@@ -1357,6 +1356,24 @@ public void setOnRangeSelectedListener(OnRangeSelectedListener listener) { | |
this.rangeListener = listener; | ||
} | ||
|
||
/** | ||
* Add listener to the title. | ||
* | ||
* @param listener thing to be notified | ||
*/ | ||
public void setOnTitleClickListener(final OnClickListener listener) { | ||
if (listener != null) { | ||
title.setOnClickListener(listener); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's wrong with setting the listener to null if it should already be guarding for null listeners There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is there something wrong with setting anull click listener? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually no, that's how you remove it! I will cleanup, thanks |
||
} | ||
} | ||
|
||
/** | ||
* Remove listener from title view. | ||
*/ | ||
public void removeOnTitleClickListener() { | ||
title.setOnClickListener(null); | ||
} | ||
|
||
/** | ||
* Dispatch date change events to a listener, if set | ||
* | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ | |
import android.support.annotation.NonNull; | ||
import android.support.v7.app.AlertDialog; | ||
import android.support.v7.app.AppCompatActivity; | ||
import android.view.View; | ||
import android.widget.DatePicker; | ||
import android.widget.LinearLayout; | ||
import android.widget.NumberPicker; | ||
|
@@ -43,6 +44,14 @@ protected void onCreate(Bundle savedInstanceState) { | |
currentTileSize = MaterialCalendarView.DEFAULT_TILE_SIZE_DP; | ||
currentTileWidth = MaterialCalendarView.DEFAULT_TILE_SIZE_DP; | ||
currentTileHeight = MaterialCalendarView.DEFAULT_TILE_SIZE_DP; | ||
|
||
widget.setOnTitleClickListener(new View.OnClickListener() { | ||
@Override | ||
public void onClick(final View view) { | ||
Toast.makeText(DynamicSettersActivity.this, "Today is the day", Toast.LENGTH_SHORT) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. string resources? or does it not matter There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
.show(); | ||
} | ||
}); | ||
} | ||
|
||
@OnClick(R.id.button_other_dates) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this being used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope