Remote Key Manager API(web3signer) #10302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
added
Enhancement
terencechain
reviewed
Apr 7, 2022
rkapka
reviewed
Apr 8, 2022
| providedPublicKeys, err := km.client.GetPublicKeys(ctx, km.publicKeysURL) | ||
| if err != nil { | ||
| erroredResponsesTotal.Inc() | ||
| return nil, errors.Wrap(err, fmt.Sprintf("could not get public keys from remote server url: %v", km.publicKeysURL)) | ||
| } | ||
| // makes sure that if the public keys are deleted the validator does not call URL again. | ||
| km.publicKeysUrlCalled = true |
There was a problem hiding this comment.
Is there no scenario where we should revert the value back to false?
There was a problem hiding this comment.
not after it starts, this is to avoid it from calling the URL endpoint accidentally after removing the last key ( when there are 0 keys)
| if found { | ||
| importedRemoteKeysStatuses[i] = ðpbservice.ImportedRemoteKeysStatus{ | ||
| Status: ethpbservice.ImportedRemoteKeysStatus_DUPLICATE, | ||
| Message: fmt.Sprintf("Duplicate pubkey: %v, already in use", hexutil.Encode(pubKey[:])), |
There was a problem hiding this comment.
Suggested change
| Message: fmt.Sprintf("Duplicate pubkey: %v, already in use", hexutil.Encode(pubKey[:])), | |
| Message: fmt.Sprintf("Duplicate pubkey: %#x, already in use", pubKey[:]), |
I think this should also work. If it does, you can make similar changes in other places.
There was a problem hiding this comment.
I tried doing this but it displays in the weird byte version not the 0x.....
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
…abs/prysm into remote-keymanager-api
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
rkapka
approved these changes
Apr 11, 2022
james-prysm
changed the title
james-prysm
changed the title
rauljordan
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
As a node operator, I would like to be able to list, import, and delete public keys defined for Prysm's Web3Signer feature.
The definitions of these APIs are consistent across all client teams and listed here. This will enable institutions to migrate keys from clients via web3signer as well as
Which issues(s) does this PR fix?
Fixes #10293