Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote Key Manager API(web3signer) #10302
Remote Key Manager API(web3signer) #10302
Changes from 32 commits
3bd159a
c9c5fe0
01de403
e237df7
73f2793
f35a35c
5c0c44d
031d590
b1392b5
a857328
924b14a
24c8629
c03b3ea
71dac89
5276364
e93835d
e3a795a
43dd405
423fbf9
7a3ce6d
c2d7414
360bd0d
47d5471
8fec645
d2fd2a5
65283cb
f120500
1f50cdd
a429761
2d591f4
b57a7a8
ecbb7ee
4cabdb0
7532a6f
03fa25e
c978c89
2be01e9
21ca459
8abd868
a69135b
ca047bd
9d30fb9
e08480c
dbefe0f
a96e4db
cd4fca2
077a2d0
65cd4e5
dee08ed
15c4e22
da1b266
180d99a
a5bd21f
431fd2f
d492320
af48fa3
c952a16
5165f82
58efca7
1fd32fe
ab2d0cc
ddbef6c
34b7fca
1d988ac
04d321b
bd08f6b
d831f14
20f4418
88c76be
652afbf
5178c97
8db0af2
1b77a58
abddb2c
720c9ba
e11c56d
afd1af9
64f6cfb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ERROR = 2 ? or are you leaving as 3 to match the DeletedKeystoreStatus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great catch need to fix this, hmm maybe i should keep it like that to match though 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment about why we're skipping 2 in here?