Scenario End To End Testing #10696
Merged
Scenario End To End Testing #10696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
E2E Tests
rauljordan
previously approved these changes
May 19, 2022
|
Some conflicts @nisdas |
rauljordan
previously approved these changes
May 19, 2022
rkapka
approved these changes
May 20, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
End To End Feature Addition
What does this PR do? Why is it needed?
This PR introduces a new feature for our end to end testing. Currently our end to end testing works in a best-case fashion. We run our end to end test suite with a pre-defined setup and the network that is setup is run is expected to pass the designated evaluators. This approach has been very useful in ensuring our builds are reliable and any new PRs being opened do not break anything. However while our end to end testing is very useful tool, it doesn't test how resilient prysm nodes are to faults in the network. (Other nodes going offline, validators going offline,etc).
Scenario Testing introduces the ability for our e2e test runner to introduce faults in the network. The ability to do this is very much needed to test edge cases with the merge coming up. Due to the interactions between the consensus and execution node, the ability to reliably test that prysm can recover from the correctly will be important. Scenario testing now introduces the ability for our test runner to pause/resume/stop any desired process that is currently running. The ability to pause/stop a process can be used to simulate faults in the network and test for any scenarios that we want.
We now have a special scenario test runner, this test runner is slightly different from our normal test runner in that it doesn't run with a few things enabled(new deposits, weak subjectivity sync, doppelganger checks, etc). If desired these cases can be added to the scenario runner. The reason we haven't added it in so far is for simplicity.
Once this is merged in, we can start work on introducing a proxy for our execution nodes and use that to modify json-rpc requests and responses.
Which issues(s) does this PR fix?
Part of #10242
Other notes for review