Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Optimistic Sync Scenario Testing #10836

Merged
merged 13 commits into from
Jun 9, 2022
Merged

Add Optimistic Sync Scenario Testing #10836

merged 13 commits into from
Jun 9, 2022

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Jun 7, 2022 •
edited
Loading

What type of PR is this?

End To End Testing

What does this PR do? Why is it needed?

This introduces optimistic sync testing in our e2e scenario test suite. In previous PRs, #10696 and #10808 we introduced the ability for our e2e test runner to perform scenario testing along with the ability to run an engine api proxy. We now combine these 2 feature with the ability to test optimistic sync.

  • Add in new scenario test for optimistic sync
  • Add in a few new features to our engine proxy, namely the ability to remove interceptors along with the ability to broadcast delayed queued up http requests.
  • Add in a few new e2e interfaces for more granular testing
  • Add in an optimistic sync evaluator.

Which issues(s) does this PR fix?

Fixes #

Other notes for review

@nisdas nisdas marked this pull request as ready for review June 8, 2022 12:12
@nisdas nisdas requested a review from a team as a code owner June 8, 2022 12:12
@nisdas nisdas requested review from kasey, terencechain and rkapka June 8, 2022 12:12
@nisdas nisdas added Ready For Review E2E Tests End-To-End testing labels Jun 8, 2022
rauljordan
rauljordan approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really awesome. Great job on putting this together and great to see it all passing

@prylabs-bulldozer prylabs-bulldozer bot merged commit 7f443e8 into develop Jun 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the addOptSyncScenario branch June 9, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
E2E Tests End-To-End testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nisdas @rauljordan