RxDocument.remove() throws on removal() when deleted

[rafamel]

await doc.remove();
console.log(doc.deleted); // true
await doc.remove();

Rx.Document.remove() is throwing instead of promise-reject. From rx-document.js:

    // ...
    remove() {
        if (this.deleted) {
            throw RxError.newRxError('DOC13', {
                document: this,
                id: this.primary
            });
        }
        // ...
      }
    //...  

I haven't sent a PR as I'm thinking this might be intentional, but since it is an async method, I do think it should reject rather than throw.

[pubkey]

You are right. It schould return a rejected promise.

[rafamel]

Sending a PR your way tonight!

[pubkey]

Hi @rafamel I added the change so calling remove() will return a rejected promise.
I still do not think that we should wrap all things in async functions because it increases the build size too much, which is already a critical factor when using RxDB. In the future, like in a year or so, we can stop shipping transpiled code and then switch to plain async/await.

[rafamel]

I agree with you @pubkey. Essentially, the rationale behind this was pure laziness. Aka, an async function will always return properly, and checking the whole codebase against it wasn't a sensible option time-wise. Ultimately, the only guarantee needs to be against the public api, so my approach would be to just check the functions susceptible of public use and ensure that they promise reject instead of throwing. It was quite a while ago, but I do remember I found a few public methods that didn't return properly (just like remove()); it might be sensible to check for promise returning functions and fix those that are a part of the public api.

Thanks for the work, @pubkey !
Rafa.