Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FIXUP) Revert incorrect path change in PDK::CLI::Exec.bundle_bin #478

Merged
merged 1 commit into from
Apr 17, 2018
Merged

(FIXUP) Revert incorrect path change in PDK::CLI::Exec.bundle_bin #478

merged 1 commit into from
Apr 17, 2018

Conversation

scotje
Copy link
Contributor

@scotje scotje commented Apr 16, 2018

Leading slashes are a thing and these two were not equivalent like I thought. :)

@coveralls
Copy link

coveralls commented Apr 16, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 92.134% when pulling 05b8470 on scotje:fixup_bundle_bin_path into d530d13 on puppetlabs:master.

@rodjek rodjek force-pushed the fixup_bundle_bin_path branch from 9c5fc18 to 05b8470 Compare April 17, 2018 04:32
rodjek
rodjek approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@rodjek rodjek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling in #479 fixed up the unrelated build failures.

@rodjek rodjek merged commit 7df5f85 into puppetlabs:master Apr 17, 2018
@chelnak chelnak added the bug label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodjek rodjek rodjek approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scotje @coveralls @rodjek @chelnak