(FM-8081) pdk new transport #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Acceptance tests fail expectedly as they need the puppetlabs/pdk-templates#251 merged first |
|
Temporarily blocked on at least adding the resource API gem to the PDK package and come up with some solution to the |
|
Added puppetlabs/puppet-module-gems#98 to make the Resource API gem part of the default bundle. I have no simpler solution for the rspec-mocks stuff than is already on the table; specifically
|
DavidS
force-pushed
the
fm-8081-pdk-new-transport
branch
from
c291d76 to
38c60fb
Compare
|
restarted travis and appveyor tests since everything else has been merged by now |
DavidS
force-pushed
the
fm-8081-pdk-new-transport
branch
from
38c60fb to
bfb384b
Compare
|
... and fixed the code |
This change implements a `pdk new transport` command for using the new Resource API transports. It is closely modelled on the `pdk new provider` command.
DavidS
force-pushed
the
fm-8081-pdk-new-transport
branch
from
bfb384b to
8b11d9c
Compare
|
@scotje this is now complete as far as I can tell. |
|
🔥 👿 |
scotje
added a commit
that referenced
this pull request
Jul 1, 2019
Revert "Merge pull request #666 from DavidS/fm-8081-pdk-new-transport"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for puppetlabs-toy-chest/pdk-planning#31
Requires puppetlabs/pdk-templates#251