Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FM-8081) pdk new transport #696

Merged
merged 2 commits into from
Jul 26, 2019
Merged

(FM-8081) pdk new transport #696

merged 2 commits into from
Jul 26, 2019

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Jul 2, 2019

DavidS added 2 commits July 2, 2019 09:14
@DavidS
(maint) fix error messages to contain a value
292b921
@DavidS
(FM-8081) Implement pdk new transport
28c87d4 
This change implements a `pdk new transport` command for
using the new Resource API transports. It is closely
modelled on the `pdk new provider` command.
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.0%) to 92.101% when pulling 28c87d4 on DavidS:fm-8081-pdk-new-transport into 230d871 on puppetlabs:master.

@DavidS
Copy link
Contributor Author

DavidS commented Jul 2, 2019

Just rebased this and now it's passing. no idea what went wrong with #666 🤷‍♂️ :-(

@DavidS DavidS requested review from rodjek and scotje July 2, 2019 09:25
@davidmalloncares
Copy link
Contributor

Hey @scotje / @rodjek - could some of you guys give this a review please? :)

@davidmalloncares davidmalloncares merged commit 2c34863 into puppetlabs:master Jul 26, 2019
@DavidS DavidS deleted the fm-8081-pdk-new-transport branch July 26, 2019 09:26
@scotje
Copy link
Contributor

scotje commented Jul 26, 2019

Sorry, we should have been more communicative, I think the plan was to review/merge this for the next release cycle.

@rodjek @glennsarti what do you all think about whether or not we should leave this in for the July release?

@rodjek
Copy link
Contributor

rodjek commented Jul 28, 2019

As it's marked as experimental, @jbondpdx shouldn't need to create any docs for it (going by the precedent set by pdk bundle), so I don't see any problem with making it part of the July release.

@rodjek
Copy link
Contributor

rodjek commented Jul 28, 2019

Situations like this add further impetus to getting the UI for pdk config prioritised as this is a perfect candidate for releasing a new feature behind a feature flag.

@davidmalloncares
Copy link
Contributor

Thanks guys :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodjek rodjek Awaiting requested review from rodjek

@scotje scotje Awaiting requested review from scotje

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DavidS @coveralls @davidmalloncares @scotje @rodjek @chelnak