MODULES-6363: fix disable dhclient (#439)

* update ntp::disable_dhclient to remove dhclient ntp script which causes flop

* add spec test

* adjust style

* created new spec helper as I updated the wrong one.  disable_dhclient did not exist

* fix syntax issue

* adjust testing for Travis CI

* adjust testing pass Travis CI

* remove extra end

* fighting the ends

* please appease the travis ci gods

* please appease the travis ci gods

* remove backup creation

* rubocop pass!

* disable_monitoring_spec.rb is a bad example to try to follow

* .

* trying again

* if at first you dont succeed, bash on the keyboard some more

* if at first you dont succeed, bash on the keyboard some more

* if at first you dont succeed, bash on the keyboard some more

* doh!

* if disable_dhclient => false do nothing

* remove unnecessary spacing

* fix absent file test

* udpate

* fix syntax

* fix syntax

* put test in right location and delete all the crazy stuff i was doing for no reason

manifests/config.pp

@@ -94,5 +94,10 @@
     file { '/var/lib/ntp/ntp.conf.dhcp':
       ensure => absent,
     }
+
+    #remove dhclient ntp script which modifies ntp.conf on RHEL and Amazon Linux
+    file { '/etc/dhcp/dhclient.d/ntp.sh':
+      ensure => absent,
+    }
   }
 }

spec/classes/ntp_spec.rb

@@ -233,6 +233,9 @@
             it 'contains dhcp file' do
               is_expected.to contain_file('/var/lib/ntp/ntp.conf.dhcp').with_ensure('absent')
             end
+            it 'contains ntp.sh file' do
+              is_expected.to contain_file('/etc/dhcp/dhclient.d/ntp.sh').with_ensure('absent')
+            end
           end
           context 'when set to false' do
             let(:params) do