(MODULES-6363) fix disabling dhclient on redhat-derivatives #439
Conversation
|
Closing and reopening to resolve Travis/bundler issues, this is caused due to https://tickets.puppetlabs.com/browse/MODULES-6339. |
|
Hey @sudodevnull if you are able to add a test for this I will get it merged. |
|
Hi @sudodevnull thanks for submitting this, we appreciate the input. If you have the time to add a test it will help us to get it merged into master. Thanks! |
manifests/config.pp
Outdated
| #backup created in case admin wants to revert back to dhclient | ||
| file { '/etc/dhcp/dhclient.d/ntp.sh': | ||
| ensure => absent, | ||
| backup => true, |
There was a problem hiding this comment.
This would unexpectedly override global file bucket policy, I think this should be left up to user of the module, or make it configurable
There was a problem hiding this comment.
do you mean for creating a backup?
There was a problem hiding this comment.
done. Also, please ignore my many commits... first time writing testing, and fighting the travis ci.
There was a problem hiding this comment.
Maintainer will ask you to squash them into one, when it's finalized
|
test is there! lol at all my crazy commits for testing. |
|
@sudodevnull thank you for your time and patience on this PR! It is much appreciated. |
DavidS
changed the title
DavidS
changed the title
Remove ntp script in RHEL and Amazon Linux (maybe others?) which causes flop. Disabling dhclient does not stop dhclient binaries from modifying ntp.conf without removing this file. I linked my open case with puppet support in the pr as I