Fix ASV benchmark configuration issues; don't run benchmarks on non-m…

…aster fork branches (#1542)

* don't think we need the sed/tee stuff

* better asv workflow job name

* don't call setup.py for pvlib build

* fiddling

* fiddle

* verbose

* fiddle

* clean up the mess

* push: only trigger for master branch

* tabs vs spaces...

.github/workflows/asv_check.yml

@@ -1,10 +1,15 @@
 name: asv
 
 # CI ASV CHECK is aimed to verify that the benchmarks execute without error.
-on: [pull_request, push]
+on:
+  push:
+    branches:
+    - master
+  pull_request:
+
 
 jobs:
-  quick:
+  quick-benchmarks:
     runs-on: ubuntu-latest
     defaults: 
       run:
@@ -27,8 +32,4 @@ jobs:
         run: |
           cd benchmarks
           asv machine --yes
-          asv run HEAD^! --quick --dry-run --show-stderr | sed "/failed$/ s/^/##[error]/" | tee benchmarks.log
-          if grep "failed" benchmarks.log > /dev/null ; then
-              exit 1
-          fi
-        
+          asv run HEAD^! --quick --dry-run --show-stderr

benchmarks/asv.conf.json

@@ -23,10 +23,9 @@
     //
     // "install_command": ["in-dir={env_dir} python -mpip install {wheel_file}"],
     // "uninstall_command": ["return-code=any python -mpip uninstall -y {project}"],
-    // "build_command": [
-    //     "python setup.py build",
-    //     "PIP_NO_BUILD_ISOLATION=false python -mpip wheel --no-deps --no-index -w {build_cache_dir} {build_dir}"
-    // ],
+    "build_command": [
+        "python -m build -o {build_cache_dir}",
+    ],
 
     // List of branches to benchmark. If not provided, defaults to "master"
     // (for git) or "default" (for mercurial).
@@ -115,6 +114,7 @@
         // minimum supported versions
         {
             "python": "3.7",
+            "build": "",
             "numpy": "1.16.0",
             "pandas": "0.25.0",
             "scipy": "1.2.0",
@@ -126,6 +126,7 @@
         // latest versions available
         {
             "python": "3.8",
+            "build": "",
             "numpy": "",
             "pandas": "",
             "scipy": "",