Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ASV benchmark configuration issues; don't run benchmarks on non-master fork branches #1542

Merged
merged 10 commits into from
Nov 11, 2022

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Aug 31, 2022

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • [ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR fixes several things:

  • First, the ASV jobs have been failing since Use pep517/518 build system for modern build isolation #1495 because asv defaults to calling setup.py and wasn't calculating the version string correctly anymore. This affected both our "quick" CI check and the nightly VM job.
  • Second, the "quick" CI check wasn't reporting those failures correctly to the github UI, so it showed up as a green check mark instead of a red X.
  • Third, address @wholmgren's comment regarding the CI check for forks: CI asv check #1454 (comment)

@kandersolar kandersolar added this to the 0.9.3 milestone Aug 31, 2022
@kandersolar kandersolar marked this pull request as ready for review August 31, 2022 15:15
@kandersolar kandersolar mentioned this pull request Sep 8, 2022
@kandersolar kandersolar modified the milestones: 0.9.3, 0.9.4 Sep 14, 2022
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kanderso-nrel I ran the asv locally without issues and reviewed the code changes (to my best efforts). So from my side it looks good, though that might not be saying much

@kandersolar
Copy link
Member Author

Thanks @AdamRJensen, yeah this stuff isn't the easiest to review. The good news is that this isn't really critical infrastructure either :) I think the real proof of review will just be to keep an eye on the asv runs and make sure they're doing the right thing, so I'll go ahead and merge this now.

@kandersolar kandersolar merged commit a741799 into pvlib:main Nov 11, 2022
@kandersolar kandersolar deleted the ci-asv-fix branch November 11, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants