Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pylint requirement from ~=2.13.4 to ~=2.13.5 #1503

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 7, 2022

Updates the requirements on pylint to permit the latest version.

Changelog

Sourced from pylint's changelog.

What's New in Pylint 2.13.5?

Release date: 2022-04-06

  • Fix false positive regression in 2.13.0 for used-before-assignment for homonyms between variable assignments in try/except blocks and variables in subscripts in comprehensions.

    Closes #6069 Closes #6136

  • lru-cache-decorating-method has been renamed to cache-max-size-none and will only be emitted when maxsize is None.

    Closes #6180

  • Fix false positive for unused-import when disabling both used-before-assignment and undefined-variable.

    Closes #6089

  • Narrow the scope of the unnecessary-ellipsis checker to:

    • functions & classes which contain both a docstring and an ellipsis.
    • A body which contains an ellipsis nodes.Expr node & at least one other statement.
  • Fix false positive for used-before-assignment for assignments taking place via nonlocal declarations after an earlier type annotation.

    Closes #5394

  • Fix crash for redefined-slots-in-subclass when the type of the slot is not a const or a string.

    Closes #6100

  • Only raise not-callable when all the inferred values of a property are not callable.

    Closes #5931

  • Fix a false negative for subclassed-final-class when a set of other messages were disabled.

What's New in Pylint 2.13.4?

Release date: 2022-03-31

  • Fix false positive regression in 2.13.0 for used-before-assignment for homonyms between variable assignments in try/except blocks and variables in a comprehension's filter.

    Closes #6035

... (truncated)

Commits
  • 95cbd2b Bump pylint to 2.13.5, update changelog
  • 2e9b33b Bump black from 22.1.0 to 22.3.0 (#6176)
  • f251131 Add subclassed-final-class message to the check_messages decorator (#...
  • a03b6e7 Prevent used-before-assignment for assignment via nonlocal after type annot...
  • 0741313 Only emit lru-cache-decorating-method when maxsize is None (#6181)
  • 7024743 Fix false positive for unused-import when disabling both ``used-before-as...
  • 4213b3c Fix handling of "for x in x" homonyms (#6154)
  • 22b5dc1 Account for more node types in handling of except block homonyms with compreh...
  • 0599016 redefined-slots-in-subclass crash when slot type is neither a string or c...
  • c48c45a Fix E1102 / not-callable false positive for property that returns a lambd...
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependency Related to dependencies of the project label Apr 7, 2022
@coveralls
Copy link

coveralls commented Apr 7, 2022

Pull Request Test Coverage Report for Build 2168376144

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 91.502%

Totals Coverage Status
Change from base Build 2167190902: -0.003%
Covered Lines: 9088
Relevant Lines: 9932

💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.12.0 milestone Apr 7, 2022
@jacobtylerwalls jacobtylerwalls modified the milestones: 2.12.0, 2.11.3 Apr 10, 2022
@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented Apr 10, 2022

Moving the milestone because it's blocking #1505 EDIT: ah, I see we've been merging other maintenance PRs, so I'll set the milestone back. sorry for the churn! :-)

@jacobtylerwalls jacobtylerwalls modified the milestones: 2.11.3, 2.12.0 Apr 14, 2022
Updates the requirements on [pylint](https://github.com/PyCQA/pylint) to permit the latest version.
- [Release notes](https://github.com/PyCQA/pylint/releases)
- [Changelog](https://github.com/PyCQA/pylint/blob/main/ChangeLog)
- [Commits](pylint-dev/pylint@v2.13.4...v2.13.5)

---
updated-dependencies:
- dependency-name: pylint
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the dependabot/pip/pylint-approx-eq-2.13.5 branch from 5a1ea03 to 0cc7056 Compare April 14, 2022 13:27
@Pierre-Sassoulas
Copy link
Member

The change to the cache were discussed in another MR that I'm too lazy to find right now. #1504 (comment) what do you think about this @jacobtylerwalls ?

@Pierre-Sassoulas
Copy link
Member

The cache change were mixed with pylint's upgrade because at first I thought it would be a straightforward fix. Then we abandoned it in #1504 because we thought that #1242 would be the way to fix it. It has been stale for some time now so we might want to have a temporary solution.

@jacobtylerwalls
Copy link
Member

Let's merge this and then rebase #1242. The PRs don't overlap much now that the scope of this one is smaller. This one only makes one substantive change, and it unblocks CI. Larger PRs get overtaken by passing PRs speeding by them all the time :-)

Honestly having not looked at #1242 I would want to see some sort of benchmark to make sure it's solving a problem. (And I'm not sure it captures all the discussion on the linked issue.)

@jacobtylerwalls
Copy link
Member

(I shouldn't have made #1242 sound so mysterious. I gave it a little skim and see how it will help.)

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the dependabot/pip/pylint-approx-eq-2.13.5 branch from ebbedec to 4f0951d Compare April 14, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Related to dependencies of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants