Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement display_type() on Slice #2365

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Implement display_type() on Slice #2365

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b48730
Implement display_type() on Slice
jacobtylerwalls Jan 27, 2024
8432264
Remove unrelated change
jacobtylerwalls Jan 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion astroid/nodes/node_classes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3513,7 +3513,7 @@


class Slice(NodeNG):
"""Class representing an :class:`ast.Slice` node.
"""Class representing a :class:`ast.Slice` node.
jacobtylerwalls marked this conversation as resolved.
Show resolved Hide resolved

>>> import astroid
>>> node = astroid.extract_node('things[1:3]')
Expand Down Expand Up @@ -3564,6 +3564,13 @@
"""
return "builtins.slice"

def display_type(self) -> Literal["Slice"]:
"""A human readable type of this node.

:returns: The type of this node.
"""
return "Slice"

Check warning on line 3572 in astroid/nodes/node_classes.py

View check run for this annotation

Codecov / codecov/patch

astroid/nodes/node_classes.py#L3572 

Added line #L3572 was not covered by tests

def igetattr(
self, attrname: str, context: InferenceContext | None = None
) -> Iterator[SuccessfulInferenceResult]:
Expand Down
Loading