-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix False positive on Enum.__members__.items() #4135
Conversation
* Don't check directories starting with '.' when using register_plugins * CI - Add benchmark job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fix, we're going to cherry-pick it to 2.7.2, could you rebase and add a quick summary in What's New in Pylint 2.7.2?
in Changelog
, please ?
Would probably permit to have the version more often and to have something to do a functional test with more often too.
Sure, maybe I could also add |
+1, closing two bugs with one MR is always nice :D |
Thank you for the update @ikraduya , I'll merge as soon as pre-commit is fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase this branch onto the current master
and force push it?
That would take care of some duplicate commits.
@ikraduya we have a deadline sunday 28 at 8pm (tomorrow) for the release of |
Co-authored-by: Marc Mueller <[email protected]>
I squashed everything and used the fix by @cdce8p, it's all good. Thank you for the fix ! |
Steps
doc/whatsnew/<current release.rst>
.Description
Fix #4123 issue about "False positive on
Enum.__members__.items()
". I add a conditional at_emit_no_member
function in typecheck.py.I am curious if there are any other cases similar to this one.
Type of Changes
Related Issue
Closes #4123