-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a false positive with singledispatchmethod-function
#9599
Merged
mbyrnepr2
merged 3 commits into
pylint-dev:main
from
mbyrnepr2:9531_fp_singledispatchmethod-function
May 7, 2024
Merged
Fix a false positive with singledispatchmethod-function
#9599
mbyrnepr2
merged 3 commits into
pylint-dev:main
from
mbyrnepr2:9531_fp_singledispatchmethod-function
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦thod is decorated with both ``functools.singledispatchmethod`` and ``staticmethod``. Closes pylint-dev#9531
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9599 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 173 173
Lines 18833 18835 +2
=======================================
+ Hits 18046 18049 +3
+ Misses 787 786 -1
|
Pierre-Sassoulas
added
False Positive π¦
A message is emitted but nothing is wrong with the code
backport maintenance/3.3.x
labels
May 6, 2024
Pierre-Sassoulas
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice python 3.7 cleanup !
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
May 7, 2024
β¦9605) * Fix a false positive with ``singledispatchmethod-function`` when a method is decorated with both ``functools.singledispatchmethod`` and ``staticmethod``. Closes #9531 (cherry picked from commit 6df4e1d) Co-authored-by: Mark Byrne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix a false positive with
singledispatchmethod-function
when a method is decorated with bothfunctools.singledispatchmethod
andstaticmethod
.Closes #9531