Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport maintenance/3.1.x] Fix a false positive with singledispatchmethod-function #9605

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 7, 2024

Backport 6df4e1d from #9599.

* Fix a false positive with ``singledispatchmethod-function`` when a method is decorated with both ``functools.singledispatchmethod`` and ``staticmethod``.

Closes #9531

(cherry picked from commit 6df4e1d)
@mbyrnepr2 mbyrnepr2 added the False Positive 🦟 A message is emitted but nothing is wrong with the code label May 7, 2024
@mbyrnepr2 mbyrnepr2 added this to the 3.1.1 milestone May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (cf102ff) to head (c9fea28).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           maintenance/3.1.x    #9605   +/-   ##
==================================================
  Coverage              95.82%   95.83%           
==================================================
  Files                    173      173           
  Lines                  18803    18805    +2     
==================================================
+ Hits                   18018    18021    +3     
+ Misses                   785      784    -1     
Files Coverage Δ
pylint/checkers/stdlib.py 96.94% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

@Pierre-Sassoulas Pierre-Sassoulas merged commit 461831f into maintenance/3.1.x May 7, 2024
25 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-9599-to-maintenance/3.1.x branch May 7, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants