Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolvelib: Consider a project "not found" if its PyPI project page has no links #357

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

tetsuo-cpp
Copy link
Contributor

Closes #356

@tetsuo-cpp tetsuo-cpp added bug Something isn't working component:dep-sources Dependency sources labels Aug 24, 2022
@tetsuo-cpp tetsuo-cpp requested a review from woodruffw August 24, 2022 13:08
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nonblocking nit, otherwise LGTM!

@woodruffw woodruffw merged commit 62481f2 into main Aug 24, 2022
@woodruffw woodruffw deleted the alex/pypi-no-links branch August 24, 2022 18:12
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 9, 2022
## [2.4.4]

### Changed

* `pip-audit` is now a PyPA member project, and lives under
  [`pypa/pip-audit`](https://github.com/pypa/pip-audit)!

* Improved error message for when unpinned URL requirements are found during an
  audit with the `--no-deps` flag
  ([#355](pypa/pip-audit#355))

### Fixed

* Fixed an issue where packages on PyPI with no published versions trigger a
  dependency resolution failure instead of being skipped
  ([#357](pypa/pip-audit#357))

* Fixed an incorrect assertion triggering for non-editable URL requirements that
  don't have an egg fragment
  ([#359](pypa/pip-audit#359))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:dep-sources Dependency sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency resolution errors for URL requirements that don't exist in PyPI
2 participants