Fix #5059: Replace SafeConfigParser with ConfigParser

[drunkwcodes]

Fix #5059

Here's a local test result:

test_vcs.py ....................                                         [100%]

========================== 20 passed in 0.28 seconds ==========================

Notes:

class SafeConfigParser(ConfigParser):
    """ConfigParser alias for backwards compatibility purposes."""

    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)
        warnings.warn(
            "The SafeConfigParser class has been renamed to ConfigParser "
            "in Python 3.2. This alias will be removed in future versions."
            " Use ConfigParser directly instead.",
            DeprecationWarning, stacklevel=2
        )

[pradyunsg]

Thanks for this PR @drunkwcodes!

Looking at the docs for SafeConfigParser on Py2, ConfigParser on Py2/3 and hgrc it seems to me that we'd want to use RawConfigParser on Py2 and ConfigParser(interpolation=None) on Py3.

https://www.mercurial-scm.org/doc/hgrc.5.html

[pradyunsg]

Ping @drunkwcodes! :)

[drunkwcodes]

Sorry. I changed my mind that this change maybe be held until 2020.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.