Remove last use of SafeConfigParser #5931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not seem to address #5120 (comment). |
|
@benoit-pierre thanks for review, updated PR to use RawConfigParser to avoid adding conditionals on python version. RawConfigParser has interpolation off on python3. |
cjerdonek
previously requested changes
Oct 27, 2018
cjerdonek
added
C: tests
xrmx
force-pushed
the
fix5059
branch
2 times, most recently
from
98e8b3d to
e3bce0c
Compare
cjerdonek
reviewed
Oct 27, 2018
cjerdonek
reviewed
Oct 30, 2018
|
And that typo will stay, forever. |
pradyunsg
approved these changes
Nov 8, 2018
…t/test_vcs_mercurial.py
pradyunsg
changed the title
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5059
Cheers from Bloomberg PyPA Sprint 2018