Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When pip was not installed by pip, don't show the upgrade warning #5368

Merged
merged 1 commit into from
May 22, 2018
Merged

When pip was not installed by pip, don't show the upgrade warning #5368

merged 1 commit into from
May 22, 2018

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented May 4, 2018 •
edited by pradyunsg
Loading

Implements behavior as discussed in #5346.

@hroncok
Copy link
Contributor Author

hroncok commented May 4, 2018 •
edited
Loading

And of course, I broke the tests :)

@hroncok hroncok changed the title When pip was not installed by pip, don't show the upgrade warning WIP: When pip was not installed by pip, don't show the upgrade warning May 4, 2018
@hroncok hroncok force-pushed the pip-nowarn-upgrade branch 5 times, most recently from 44a700e to 5196c74 Compare May 4, 2018 14:31
@hroncok hroncok changed the title WIP: When pip was not installed by pip, don't show the upgrade warning When pip was not installed by pip, don't show the upgrade warning May 4, 2018
@hroncok
Copy link
Contributor Author

hroncok commented May 4, 2018

Fixed and added tests! Travis CI is failing with mypy, but it seems unrelated.

@hroncok hroncok mentioned this pull request May 4, 2018
Closed
@hroncok
Copy link
Contributor Author

hroncok commented May 4, 2018 •
edited
Loading

Would be nice to check how this behaves on Windows. I have no idea and the monkeypatching might cover up the default behavior there.

@pradyunsg
Copy link
Member

I'll look into the mypy issues tonight.

@pradyunsg
Copy link
Member

master should be fixed, thanks to @DanielShaulov! :)

@hroncok
Copy link
Contributor Author

hroncok commented May 5, 2018

OK, let's rebase this.

@hroncok hroncok force-pushed the pip-nowarn-upgrade branch from 5196c74 to e4a4b91 Compare May 5, 2018 10:01
pradyunsg
pradyunsg approved these changes May 10, 2018
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the news file.

news/5346.bugfix Outdated
@@ -0,0 +1,3 @@
When pip is installed by another package manager (mostly Linux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Disable pip's version check (and upgrade message) when installed by a different package manager.

This works better with Linux distributions where pip's upgrade message may 
result in users running pip in a manner that modifies files that should be 
managed by the OS's package manager.

The first line being long is fine. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a10c7229691f8311376ee25457b303d605436e54

@pradyunsg pradyunsg added the S: needs triage Issues/PRs that need to be triaged label May 11, 2018
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label May 18, 2018
@hroncok hroncok force-pushed the pip-nowarn-upgrade branch from a10c722 to d0b7708 Compare May 19, 2018 06:32
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label May 19, 2018
@pradyunsg pradyunsg added type: enhancement Improvements to functionality and removed S: needs triage Issues/PRs that need to be triaged labels May 22, 2018
@pradyunsg pradyunsg merged commit 8619e3e into pypa:master May 22, 2018
@pradyunsg pradyunsg added this to the 18.0 milestone May 22, 2018
@hroncok hroncok deleted the pip-nowarn-upgrade branch May 22, 2018 09:10
@hroncok
Copy link
Contributor Author

hroncok commented May 22, 2018

Thanks @pradyunsg

@pradyunsg pradyunsg mentioned this pull request Jul 15, 2018
Merged
@nehaljwani nehaljwani mentioned this pull request Jul 15, 2018
Open
@jjhelmus jjhelmus mentioned this pull request Oct 8, 2018
Closed
@xavfernandez xavfernandez mentioned this pull request Oct 9, 2018
Closed
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation type: enhancement Improvements to functionality
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hroncok @pradyunsg @BrownTruck @pypa-bot