Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention package manager. #5689

Closed
wants to merge 1 commit into from
Closed

Conversation

rainwoodman
Copy link

When an external package manager exists, the current recommendation can be confusing and may even be broken.
This PR mentions the package manager in the recommended action, in the hope of providing some hint when things go bad.

No need for news.

When an external package manager exists, the current recommendation can be confusing and may even be broken.
This PR mentions the package manager in the recommended action, in the hope of providing some hint when things go bad.
@xavfernandez
Copy link
Member

With #5368 being merged, I don't think this is needed anymore...

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label May 8, 2019
@pradyunsg
Copy link
Member

pradyunsg commented May 8, 2019

Thank you for filing this! I'll go ahead and close this in favor of #6468.

@pradyunsg pradyunsg closed this May 8, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation needs rebase or merge PR has conflicts with current master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants