-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.10] gh-97032: avoid test_squeezer crash on macOS buildbots #115508
Conversation
!buildbot x86-64 macOS PR |
🤖 New build scheduled with the buildbot fleet by @ned-deily for commit 08ecd09 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
!buildbot ARM64 MacOS |
🤖 New build scheduled with the buildbot fleet by @ned-deily for commit 08ecd09 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
!buildbot ARM64 MacOS |
PR buildbots for old branches aren't particularly stable, so it's better to look at the issues and ignore unrelated ones. @pablogsal, IMO this is the best way to fix the 3.10 & 3.9 buildbot failures. There's a more robust fix in later branches.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running IDLE on Mac with Cocoa and Apple tkinter is not supported. When I user does so, IDLE warns about stability and points to the web page about installing better tkinter.
The crash makes no sense to me; do whatever whoever thinks best.
The test failure is SIGABRT that, AFAIK, comes from inside tkinter.
That is, the tkinter that comes with the system now crashes the process at startup. AFAIK, this started happening after a system upgrade. |
While I understand the fix and the rationale, I have to say that I still find it a bit "hacky" (for the lack of a better term). Given that this is to fix CI in old branches I am fine merging it as it has no user impact, but ideally we should fix this in the build system in I any case, I am merging this as I think the proper fix will be more aggressive and we need to have the CI green to avoid hiding other problems. Thanks @encukou and @ned-deily for the PR and the explanation. |
Thanks @ned-deily for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
…ythonGH-115508) avoid test_squeezer crash on macOS buildbots (cherry picked from commit 17a6533) Co-authored-by: Ned Deily <[email protected]>
GH-115655 is a backport of this pull request to the 3.9 branch. |
…ythonGH-115508) avoid test_squeezer crash on macOS buildbots (cherry picked from commit 17a6533) Co-authored-by: Ned Deily <[email protected]>
GH-115656 is a backport of this pull request to the 3.8 branch. |
Thanks! |
GH-115655 is a backport of this pull request to the 3.9 branch. |
…) (#115655) (cherry picked from commit 17a6533) Co-authored-by: Ned Deily <[email protected]>
…) (GH-115656) (cherry picked from commit 17a6533) Co-authored-by: Ned Deily <[email protected]>
!buildbot macOS