Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] gh-97032: avoid test_squeezer crash on macOS buildbots (GH-115508) #115655

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 19, 2024

avoid test_squeezer crash on macOS buildbots
(cherry picked from commit 17a6533)

Co-authored-by: Ned Deily [email protected]

…ythonGH-115508)

avoid test_squeezer crash on macOS buildbots
(cherry picked from commit 17a6533)

Co-authored-by: Ned Deily <[email protected]>
@encukou
Copy link
Member

encukou commented Feb 20, 2024

!buildbot ARM64 MacOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 62b8d31 🤖

The command will test the builders whose names match following regular expression: ARM64 MacOS

The builders matched are:

  • ARM64 MacOS M1 Refleaks NoGIL PR
  • ARM64 MacOS M1 NoGIL PR
  • ARM64 macOS PR

@encukou
Copy link
Member

encukou commented Feb 21, 2024

PR buildbot failures are unrelated.

@ambv, IMO this is the best way to fix the 3.9 buildbot failures. There's a more robust fix in later branches.
The other approaches considered are:

  • change library detection logic, which isn't ideal in source-only security releases
  • configuring the buildbot to use Homebrew tkinter -- too much work for a library that isn't really tested anyway

See Pablo's comment for 3.10:

While I understand the fix and the rationale, I have to say that I still find it a bit "hacky" (for the lack of a better term). Given that this is to fix CI in old branches I am fine merging it as it has no user impact, but ideally we should fix this in the build system in main if we detect that we are using an incompatible tkinter .

I any case, I am merging this as I think the proper fix will be more aggressive and we need to have the CI green to avoid hiding other problems. Thanks @encukou and @ned-deily for the PR and the explanation.

In main, the build system prefers pkg-config, and shouldn't pick up Apple's abandoned tk.

@ambv ambv changed the title [3.9] [3.10] gh-97032: avoid test_squeezer crash on macOS buildbots (GH-115508) [3.9] gh-97032: avoid test_squeezer crash on macOS buildbots (GH-115508) Feb 21, 2024
@ambv ambv merged commit c23f749 into python:3.9 Feb 21, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants