Refactor conda upload job to a separate job running on GH ephemeral runner #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
malfet
approved these changes
Jan 16, 2024
huydhn
added a commit
that referenced
this pull request
Jan 17, 2024
I tested #4886 with vision nightly and found out that I need to set the path to anaconda on GH ephemeral runner used by the upload job. It would fail otherwise, i.e. https://github.com/pytorch/vision/actions/runs/7550404642/job/20556529100#step:7:121 ### Testing https://github.com/pytorch/test-infra/actions/runs/7550720719/job/20557072841?pr=4891#step:7:117 shows that conda can find anaconda client version correctly.
huydhn
added a commit
that referenced
this pull request
Feb 12, 2024
…unner (#4886) Similar to #4877, this moves conda upload into a separate job on GH ephemeral runner: * I need a new `_binary_conda_upload` reusable workflow because conda upload uses anaconda client to upload to conda, not awscli to upload to S3. * The build job doesn't have access to `pytorchbot-env` anymore, thus it has no access to `CONDA_PYTORCHBOT_TOKEN` and `CONDA_PYTORCHBOT_TOKEN_TEST` secrets. Only the upload job has this access.
huydhn
added a commit
that referenced
this pull request
Feb 12, 2024
I tested #4886 with vision nightly and found out that I need to set the path to anaconda on GH ephemeral runner used by the upload job. It would fail otherwise, i.e. https://github.com/pytorch/vision/actions/runs/7550404642/job/20556529100#step:7:121 ### Testing https://github.com/pytorch/test-infra/actions/runs/7550720719/job/20557072841?pr=4891#step:7:117 shows that conda can find anaconda client version correctly.
This was referenced Feb 12, 2024
huydhn
added a commit
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #4877, this moves conda upload into a separate job on GH ephemeral runner:
_binary_conda_uploadreusable workflow because conda upload uses anaconda client to upload to conda, not awscli to upload to S3.pytorchbot-envanymore, thus it has no access toCONDA_PYTORCHBOT_TOKENandCONDA_PYTORCHBOT_TOKEN_TESTsecrets. Only the upload job has this access.