Set channel before setup-binary-upload on upload jobs #4901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
atalman
approved these changes
Jan 22, 2024
huydhn
added a commit
that referenced
this pull request
Feb 12, 2024
As reported by @henrylhtsang that the upload jobs failed to upload to the test channel https://github.com/pytorch/torchrec/actions/runs/7616462285/job/20743869473, it turns out that I made a mistake running `setup-binary-upload` after `set-channel`, so the channel wasn't set correct and fallback to nightly default
This was referenced Feb 12, 2024
huydhn
added a commit
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @henrylhtsang that the upload jobs failed to upload to the test channel https://github.com/pytorch/torchrec/actions/runs/7616462285/job/20743869473, it turns out that I made a mistake running
setup-binary-uploadafterset-channel, so the channel wasn't set correct and fallback to nightly default