Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply $CONDA_ENV fix for smoke tests #5527

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Jul 30, 2024

Same fix already applied in conda-build step above: https://github.com/pytorch/test-infra/pull/5527/files#diff-a830234c1ab7788cbd304fa713940ab2393c8da8f7338ff31c0c08c86d9900aeR140

Fixes issue with conda picking up default test env created by:
https://github.com/conda-incubator/setup-miniconda#conda-incubatorsetup-miniconda

Test PR: pytorch/vision#8562

Failure running conda info before install (2 yrs old conda version 4.12):

+ export 'CONDA_RUN_SMOKE=conda run -p /__w/_temp/pytorch_pkg_helpers_10168573792_smoke'
+ CONDA_RUN_SMOKE='conda run -p /__w/_temp/pytorch_pkg_helpers_10168573792_smoke'
+ [[ cpu = \c\u\d\a ]]
+ CONSTRAINTS=cpuonly
+ CONSTRAINT_BUILD=
+ [[ nightly = \t\e\s\t ]]
+ conda run -p /__w/_temp/pytorch_pkg_helpers_10168573792_smoke conda info

     active environment : /__w/_temp/pytorch_pkg_helpers_10168573792_smoke
    active env location : /__w/_temp/pytorch_pkg_helpers_10168573792_smoke
            shell level : 2
       user config file : /github/home/.condarc
 populated config files : /github/home/.condarc
          conda version : 4.12.0
    conda-build version : not installed
         python version : 3.9.12.final.0
       virtual packages : __linux=4.14.336=0
                          __glibc=2.17=0
                          __unix=0=0
                          __archspec=1=x86_64
       base environment : /__w/vision/vision/3  (writable)
      conda av data dir : /__w/vision/vision/3/etc/conda
  conda av metadata url : None
           channel URLs : https://repo.anaconda.com/pkgs/main/linux-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/linux-64
                          https://repo.anaconda.com/pkgs/r/noarch
          package cache : /github/home/conda_pkgs_dir
       envs directories : /__w/vision/vision/3/envs
                          /github/home/.conda/envs
               platform : linux-64
             user-agent : conda/4.12.0 requests/2.27.1 CPython/3.9.12 Linux/4.14.336-257.562.amzn2.x86_64 centos/7.9.[200](https://github.com/pytorch/vision/actions/runs/10168573792/job/28127797690?pr=8562#step:14:201)9 glibc/2.17
                UID:GID : 0:0
             netrc file : None
           offline mode : False

Fail run: https://github.com/pytorch/vision/actions/runs/10168573792/job/28127797690?pr=8562

Success:

Executing transaction: ...working... done
+ export 'CONDA_RUN_SMOKE=conda run -p /__w/_temp/pytorch_pkg_helpers_10168573792_smoke'
+ CONDA_RUN_SMOKE='conda run -p /__w/_temp/pytorch_pkg_helpers_10168573792_smoke'
+ [[ cpu = \c\u\d\a ]]
+ CONSTRAINTS=cpuonly
+ CONSTRAINT_BUILD=
+ [[ nightly = \t\e\s\t ]]
+ conda run -p /__w/_temp/pytorch_pkg_helpers_10168573792_smoke conda info

     active environment : /__w/_temp/pytorch_pkg_helpers_10168573792_smoke
    active env location : /__w/_temp/pytorch_pkg_helpers_10168573792_smoke
            shell level : 2
       user config file : /github/home/.condarc
 populated config files : /github/home/.condarc
          conda version : 24.4.0
    conda-build version : 24.3.0
         python version : 3.9.19.final.0
                 solver : libmamba (default)
       virtual packages : __archspec=1=skylake_avx512
                          __conda=24.4.0=0
                          __glibc=2.17=0
                          __linux=4.14.336=0
                          __unix=0=0
       base environment : /__w/_temp/conda_environment_10168573792  (writable)
      conda av data dir : /__w/_temp/conda_environment_10168573792/etc/conda
  conda av metadata url : None
           channel URLs : https://repo.anaconda.com/pkgs/main/linux-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/linux-64
                          https://repo.anaconda.com/pkgs/r/noarch
          package cache : /github/home/conda_pkgs_dir
       envs directories : /__w/_temp/conda_environment_10168573792/envs
                          /github/home/.conda/envs
               platform : linux-64
             user-agent : conda/24.4.0 requests/2.32.3 CPython/3.9.19 Linux/4.14.336-257.562.amzn2.x86_64 centos/7.9.2009 glibc/2.17 solver/libmamba conda-libmamba-solver/24.7.0 libmambapy/1.5.8
                UID:GID : 0:0
             netrc file : None
           offline mode : False

Success run: https://github.com/pytorch/vision/actions/runs/10168573792/job/28128479597?pr=8562

Copy link

vercel bot commented Jul 30, 2024

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2024
@atalman
Copy link
Contributor Author

atalman commented Jul 30, 2024

Please note vision builds failing because of : pytorch/vision#8560

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but please file a follow up issue to investigate why add more and more of those fixups is necessary, as this is exactly what conda is for, isn't it?

@atalman
Copy link
Contributor Author

atalman commented Jul 30, 2024

Sound good @malfet would need to create an issue for this.

@atalman atalman merged commit 40262c4 into pytorch:main Jul 30, 2024
11 of 20 checks passed
@atalman atalman deleted the fix_nightly_vision_linux branch July 30, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants