Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict ffmpeg to 4.2+.X versions to resolve linux conda build failures #8562

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Restrict ffmpeg to 4.2+.X versions to resolve linux conda build failures #8562

merged 6 commits into from
Jul 30, 2024

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Jul 30, 2024 •
edited
Loading

Looks like ffmpeg release 6.1.1 broke our linux conda builds: https://anaconda.org/anaconda/ffmpeg/files?version=6.1.1
Fixes: #8560

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8562

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 0198c8f with merge base 09077a8 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman changed the title Update meta.yaml Pin ffmpeg to 4.2.2 - resolve linux conda build failures Jul 30, 2024
@atalman atalman mentioned this pull request Jul 30, 2024
Merged
malfet
malfet reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong with ffmpeg-4.3? (I.e. why pin it to 4.4.2, rather than allow the range?)

@malfet malfet changed the title Pin ffmpeg to 4.2.2 - resolve linux conda build failures Restrict ffmpeg to 4.2+.X versions to resolve linux conda build failures Jul 30, 2024
@atalman
Copy link
Contributor Author

atalman commented Jul 30, 2024 •
edited
Loading

Anaconda has 4.2.2 and 6.1.1 but I think its good idea to pin it to range
Screenshot 2024-07-30 at 6 17 56 PM

atalman added a commit to pytorch/test-infra that referenced this pull request Jul 30, 2024
@atalman
Apply $CONDA_ENV fix for smoke tests (#5527)
40262c4 
Same fix already applied in conda-build step above:
https://github.com/pytorch/test-infra/pull/5527/files#diff-a830234c1ab7788cbd304fa713940ab2393c8da8f7338ff31c0c08c86d9900aeR140

Fixes issue with conda picking up default test env created by:

https://github.com/conda-incubator/setup-miniconda#conda-incubatorsetup-miniconda

Test PR:  pytorch/vision#8562

Failure running conda info before install (2 yrs old conda version
4.12):
```
+ export 'CONDA_RUN_SMOKE=conda run -p /__w/_temp/pytorch_pkg_helpers_10168573792_smoke'
+ CONDA_RUN_SMOKE='conda run -p /__w/_temp/pytorch_pkg_helpers_10168573792_smoke'
+ [[ cpu = \c\u\d\a ]]
+ CONSTRAINTS=cpuonly
+ CONSTRAINT_BUILD=
+ [[ nightly = \t\e\s\t ]]
+ conda run -p /__w/_temp/pytorch_pkg_helpers_10168573792_smoke conda info

     active environment : /__w/_temp/pytorch_pkg_helpers_10168573792_smoke
    active env location : /__w/_temp/pytorch_pkg_helpers_10168573792_smoke
            shell level : 2
       user config file : /github/home/.condarc
 populated config files : /github/home/.condarc
          conda version : 4.12.0
    conda-build version : not installed
         python version : 3.9.12.final.0
       virtual packages : __linux=4.14.336=0
                          __glibc=2.17=0
                          __unix=0=0
                          __archspec=1=x86_64
       base environment : /__w/vision/vision/3  (writable)
      conda av data dir : /__w/vision/vision/3/etc/conda
  conda av metadata url : None
           channel URLs : https://repo.anaconda.com/pkgs/main/linux-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/linux-64
                          https://repo.anaconda.com/pkgs/r/noarch
          package cache : /github/home/conda_pkgs_dir
       envs directories : /__w/vision/vision/3/envs
                          /github/home/.conda/envs
               platform : linux-64
             user-agent : conda/4.12.0 requests/2.27.1 CPython/3.9.12 Linux/4.14.336-257.562.amzn2.x86_64 centos/7.9.[200](https://github.com/pytorch/vision/actions/runs/10168573792/job/28127797690?pr=8562#step:14:201)9 glibc/2.17
                UID:GID : 0:0
             netrc file : None
           offline mode : False
```
Fail run:
https://github.com/pytorch/vision/actions/runs/10168573792/job/28127797690?pr=8562

Success:
```
Executing transaction: ...working... done
+ export 'CONDA_RUN_SMOKE=conda run -p /__w/_temp/pytorch_pkg_helpers_10168573792_smoke'
+ CONDA_RUN_SMOKE='conda run -p /__w/_temp/pytorch_pkg_helpers_10168573792_smoke'
+ [[ cpu = \c\u\d\a ]]
+ CONSTRAINTS=cpuonly
+ CONSTRAINT_BUILD=
+ [[ nightly = \t\e\s\t ]]
+ conda run -p /__w/_temp/pytorch_pkg_helpers_10168573792_smoke conda info

     active environment : /__w/_temp/pytorch_pkg_helpers_10168573792_smoke
    active env location : /__w/_temp/pytorch_pkg_helpers_10168573792_smoke
            shell level : 2
       user config file : /github/home/.condarc
 populated config files : /github/home/.condarc
          conda version : 24.4.0
    conda-build version : 24.3.0
         python version : 3.9.19.final.0
                 solver : libmamba (default)
       virtual packages : __archspec=1=skylake_avx512
                          __conda=24.4.0=0
                          __glibc=2.17=0
                          __linux=4.14.336=0
                          __unix=0=0
       base environment : /__w/_temp/conda_environment_10168573792  (writable)
      conda av data dir : /__w/_temp/conda_environment_10168573792/etc/conda
  conda av metadata url : None
           channel URLs : https://repo.anaconda.com/pkgs/main/linux-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/linux-64
                          https://repo.anaconda.com/pkgs/r/noarch
          package cache : /github/home/conda_pkgs_dir
       envs directories : /__w/_temp/conda_environment_10168573792/envs
                          /github/home/.conda/envs
               platform : linux-64
             user-agent : conda/24.4.0 requests/2.32.3 CPython/3.9.19 Linux/4.14.336-257.562.amzn2.x86_64 centos/7.9.2009 glibc/2.17 solver/libmamba conda-libmamba-solver/24.7.0 libmambapy/1.5.8
                UID:GID : 0:0
             netrc file : None
           offline mode : False
```
Success run:
https://github.com/pytorch/vision/actions/runs/10168573792/job/28128479597?pr=8562
@atalman atalman merged commit 61bd547 into main Jul 30, 2024
74 of 77 checks passed
@atalman atalman deleted the atalman-patch-4 branch July 30, 2024 22:50
@github-actions GitHub Actions
Copy link

Hey @atalman!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Aug 2, 2024
@NicolasHug @facebook-github-bot
[fbsync] Restrict ffmpeg to 4.2+.X versions to resolve linux conda bu…
850f45d 
…ild failures (#8562)

Summary: Co-authored-by: Nikita Shulga <[email protected]>

Reviewed By: vmoens

Differential Revision: D60596216

fbshipit-source-id: 6cf162d9998f39b3e2c2035dc7a341d3018d8c1e
atalman added a commit to atalman/vision that referenced this pull request Aug 23, 2024
@atalman @malfet
Restrict ffmpeg to 4.2+.X versions to resolve linux conda build failu…
75e6c3f 
…res (pytorch#8562)

Co-authored-by: Nikita Shulga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux conda build jobs are failing
3 participants
@atalman @malfet @facebook-github-bot