Correct torchao check for TensorCoreTiledLayout
#1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1886
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d3d58d7 with merge base 1e5f0d5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
SalmanMohammadi
approved these changes
Oct 23, 2024
13 tasks
andrewor14
added a commit
to andrewor14/torchtune
that referenced
this pull request
Oct 28, 2024
Summary: Fixes pytorch#1908. Previous attempts (pytorch#1886) to fix this issue still break in local settings, so it's more robust and simpler to just try catch the import error. Test Plan: ``` from torchtune.training.quantization import * ```
andrewor14
added a commit
to andrewor14/torchtune
that referenced
this pull request
Oct 28, 2024
Summary: Fixes pytorch#1908. Previous attempts (pytorch#1886) to fix this issue still break in local settings, so it's more robust and simpler to just try catch the import error. Test Plan: ``` from torchtune.training.quantization import * ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
My guess is the RC was already cut by the time this change was made, so it didn't actually make it into the 0.6.0 release. However, we thought it was going to be in there b/c we didn't check the RC tag.
Changelog
What are the changes made in this PR?
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install)pytest testspytest tests -m integration_test