Make TensorCoreTiledLayout import more robust #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1912
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9984016 with merge base d3039da ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@joecummings @ebsmothers @jainapurva Can you please take a look? |
ebsmothers
reviewed
Oct 28, 2024
torchtune/utils/_import_guard.py
Outdated
| @@ -16,14 +16,3 @@ | |||
| ) | |||
|
|
|||
| torchao_version = torchao.__version__ | |||
There was a problem hiding this comment.
nit: can remove this too
ebsmothers
approved these changes
Oct 28, 2024
Summary: Fixes pytorch#1908. Previous attempts (pytorch#1886) to fix this issue still break in local settings, so it's more robust and simpler to just try catch the import error. Test Plan: ``` from torchtune.training.quantization import * ```
andrewor14
force-pushed
the
fix-layout-version
branch
from
86f15ca
to
9984016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fixes #1908. Previous attempts (#1886) to fix this issue still break in local settings, so it's more robust and simpler to just try catch the import error.
Test Plan: